From 974814af105efcd160f72d977c48c034b57a06d3 Mon Sep 17 00:00:00 2001 From: vinkja Date: Tue, 29 Oct 2019 07:55:49 +0100 Subject: [PATCH 1/2] personTest ergaenzt --- src/test/java/assertions/PersonTest.java | 39 ++++++++++++++++-------- 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/src/test/java/assertions/PersonTest.java b/src/test/java/assertions/PersonTest.java index eb0f3f7..064659d 100644 --- a/src/test/java/assertions/PersonTest.java +++ b/src/test/java/assertions/PersonTest.java @@ -1,9 +1,10 @@ package assertions; +import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.Test; -import sun.reflect.generics.reflectiveObjects.NotImplementedException; import java.time.LocalDate; +import java.time.Period; class PersonTest { @@ -11,29 +12,43 @@ class PersonTest { @Test void getFullNameReturnsFirstnameSpaceLastname(){ - // TODO implement - throw new NotImplementedException(); - } + Person p1 = new Person("Gion", "Baptista", LocalDate.of(1987, 1,1)); + String fullName = p1.getFullName(); - // TODO some more useful tests + Assertions.assertEquals(fullName, "Gion Baptista"); + } - // getAge + @Test + void getAgeReturnsAgeInYears() { + Person p1 = new Person("Gion", "Baptista", LocalDate.of(1987, 8,7)); + Period age = p1.getAge(); + Assertions.assertEquals(32, age.getYears()); + Assertions.assertEquals(2, age.getMonths()); + Assertions.assertEquals(22,age.getDays()); + } - // TODO verbessern. Hinweis: Repeatable (wiederholbar) zu jeder Zeit. @Test void getAgeReturns10YearsIfBornIn2009() throws Exception { - Person p = new Person("", "", LocalDate.of(2009, 1, 1)); + Person p = new Person("", "",LocalDate.now().minusYears(10)); + + Period age = p.getAge(); + + Assertions.assertEquals(10, age.getYears()); + Assertions.assertEquals(0, age.getMonths()); + Assertions.assertEquals(0,age.getDays()); - throw new NotImplementedException(); } @Test void getAgeReturns1DayIfYesterday() throws Exception { Person p = new Person("", "", LocalDate.now().minusDays(1)); - // TODO implement - throw new NotImplementedException(); + Period age = p.getAge(); + + Assertions.assertEquals(0, age.getYears()); + Assertions.assertEquals(0, age.getMonths()); + Assertions.assertEquals(1,age.getDays()); } - // TODO some more useful tests + } \ No newline at end of file From 9e9d16ef52fb851de1826e9c063608839024865e Mon Sep 17 00:00:00 2001 From: vinkja Date: Fri, 1 Nov 2019 09:41:25 +0100 Subject: [PATCH 2/2] 1 zus. Methode inkl. UnitTest --- src/main/java/assertions/Person.java | 5 ++++ src/test/java/assertions/PersonTest.java | 29 +++++++++++----------- src/test/java/fakes/UserValidatorTest.java | 14 +++++------ 3 files changed, 26 insertions(+), 22 deletions(-) diff --git a/src/main/java/assertions/Person.java b/src/main/java/assertions/Person.java index ac7666b..7fd7de6 100644 --- a/src/main/java/assertions/Person.java +++ b/src/main/java/assertions/Person.java @@ -22,4 +22,9 @@ public String getFullName(){ public Period getAge(){ return Period.between(birthDate, LocalDate.now()); } + + public String getAgeToString() { + Period p = getAge(); + return "Age: " + p.getYears() + " Years, " + p.getMonths() + " Months, " + p.getDays() + " Days."; + } } diff --git a/src/test/java/assertions/PersonTest.java b/src/test/java/assertions/PersonTest.java index 064659d..540fd63 100644 --- a/src/test/java/assertions/PersonTest.java +++ b/src/test/java/assertions/PersonTest.java @@ -19,29 +19,20 @@ void getFullNameReturnsFirstnameSpaceLastname(){ } @Test - void getAgeReturnsAgeInYears() { - Person p1 = new Person("Gion", "Baptista", LocalDate.of(1987, 8,7)); - Period age = p1.getAge(); - - Assertions.assertEquals(32, age.getYears()); - Assertions.assertEquals(2, age.getMonths()); - Assertions.assertEquals(22,age.getDays()); - } - - @Test - void getAgeReturns10YearsIfBornIn2009() throws Exception { - Person p = new Person("", "",LocalDate.now().minusYears(10)); + void getAgeReturns10YearsIfBorn10y5m12dAgo() { + Person p = new Person("", "",LocalDate.now().minusYears(10).minusMonths(5).minusDays(12)); Period age = p.getAge(); + System.out.println(age); Assertions.assertEquals(10, age.getYears()); - Assertions.assertEquals(0, age.getMonths()); - Assertions.assertEquals(0,age.getDays()); + Assertions.assertEquals(5, age.getMonths()); + Assertions.assertEquals(12,age.getDays()); } @Test - void getAgeReturns1DayIfYesterday() throws Exception { + void getAgeReturns1DayIfYesterday() { Person p = new Person("", "", LocalDate.now().minusDays(1)); Period age = p.getAge(); @@ -51,4 +42,12 @@ void getAgeReturns1DayIfYesterday() throws Exception { Assertions.assertEquals(1,age.getDays()); } + @Test + void getAgeToStringReturnsAgeAsString() { + Person p = new Person("", "",LocalDate.now().minusYears(10).minusMonths(5).minusDays(12)); + System.out.println(p.getAgeToString()); + + Assertions.assertEquals("Age: 10 Years, 5 Months, 12 Days.", p.getAgeToString()); + } + } \ No newline at end of file diff --git a/src/test/java/fakes/UserValidatorTest.java b/src/test/java/fakes/UserValidatorTest.java index 0c2ceac..ecdf4fc 100644 --- a/src/test/java/fakes/UserValidatorTest.java +++ b/src/test/java/fakes/UserValidatorTest.java @@ -2,7 +2,7 @@ import org.junit.jupiter.api.Nested; import org.junit.jupiter.api.Test; -import sun.reflect.generics.reflectiveObjects.NotImplementedException; + class UserValidatorTest { @@ -11,22 +11,22 @@ class isValidUsername{ @Test void returnsTrueIfOnlyLetters(){ - throw new NotImplementedException(); + } @Test void returnsFalseIfStartsWithNumber(){ - throw new NotImplementedException(); + } @Test void returnsTrueIfContainsNumberButNotAsFirstChar(){ - throw new NotImplementedException(); + } @Test void returnsFalseIfContainsAnyNonAlphanumericChar(){ - throw new NotImplementedException(); + } } @@ -34,12 +34,12 @@ static class doesUsernameExist{ @Test void returnsTrueIfUsernameNotInDBYet(){ - throw new NotImplementedException(); + } @Test void returnsFalseIfUsernameInDB(){ - throw new NotImplementedException(); + } } }