Open
Description
@ShiveshM has developed a very useful successor to the Events
object in the Data
object (see $PISA/pisa/core/events.py, same file for both classes). This allows for "dynamically" combining flavints together (might still be some work to get weights right) and also generalizes simply to noise and mouons (and presumably other things we can throw at it).
He has also made this a shared object that can be used by all stages in his pipeline, eliminating redundancy and ensuring consistency in the events that are used by each stage. This is a behavior we should replicate in all the stages.
- Possibly rename
Data
toEvents
, replacing theEvents
object. (That name seems more general, sincedata
is a very specific thing, whileEvents
can include noise, muons, background, MC, etc., etc. and data. - We want to ensure access to events is one level and accessing properties for events is two levels of hierarchy within the object (vs. the 3 levels for the Events object (
events[flav][int]
)... which just has a veneer of 2-level indexing but this doesn't generalize well at all now) - Might be a good time to make
NuFlavInt*
work with muons, noise, (background), ... etc.; OR create a higher-level parser (or class?) that can deal with the various categories of things we might have in our data.
There are probably many other issues to consider, so feel free to add any you can think of.