Skip to content

Convert all PISA code to use the Data object...  #364

Open
@jllanfranchi

Description

@jllanfranchi

@ShiveshM has developed a very useful successor to the Events object in the Data object (see $PISA/pisa/core/events.py, same file for both classes). This allows for "dynamically" combining flavints together (might still be some work to get weights right) and also generalizes simply to noise and mouons (and presumably other things we can throw at it).

He has also made this a shared object that can be used by all stages in his pipeline, eliminating redundancy and ensuring consistency in the events that are used by each stage. This is a behavior we should replicate in all the stages.

  • Possibly rename Data to Events, replacing the Events object. (That name seems more general, since data is a very specific thing, while Events can include noise, muons, background, MC, etc., etc. and data.
  • We want to ensure access to events is one level and accessing properties for events is two levels of hierarchy within the object (vs. the 3 levels for the Events object (events[flav][int])... which just has a veneer of 2-level indexing but this doesn't generalize well at all now)
  • Might be a good time to make NuFlavInt* work with muons, noise, (background), ... etc.; OR create a higher-level parser (or class?) that can deal with the various categories of things we might have in our data.

There are probably many other issues to consider, so feel free to add any you can think of.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions