Skip to content

Inconsistent naming of tree parameter in Widget trait #2949

Open
@mfreeborn

Description

@mfreeborn

Is your issue REALLY a bug?

  • My issue is indeed a bug!
  • I am not crazy! I will not fill out this form just to ask a question or request a feature. Pinky promise.

Is there an existing issue for this?

  • I have searched the existing issues.

Is this issue related to iced?

  • My hardware is compatible and my graphics drivers are up-to-date.

What happened?

https://docs.iced.rs/iced/advanced/trait.Widget.html

The provided methods of the Widget trait use the name _state, whereas the required methods use tree, and it is these names which the IDE uses when auto-completing new methods that I want to impl on the trait.

tree is nicer, because then I can write let state = tree.state.downcast_ref::<...>() without shadowing the original Tree.

For consistency, it would be nicer to rename occurrences of _state to _tree. Saves me having to rewrite the parameter's name in its entirety vs just deleting the leading underscore if I want to use it in my impl.

What is the expected behavior?

.

Version

master

Operating System

Linux

Do you have any log output?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions