You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge PR 5, ci: restore aws-lc-rs crypto provider, use cargo-c for librustls install
commit 3280e4f
Author: Daniel McCarney <[email protected]>
Date: Sat Jan 18 10:37:15 2025 -0500
ci: restore aws-lc-rs crypto provider in matrix
This works without issue with the main branch of rustls-ffi.
For the 0.14.1 release when using the Makefile to install there's an
upstream issue where the CFLAGS intended for the rustls-ffi
client/server examples are _also_ used when building librustls and its
rust dependencies.
This includes aws-lc-sys, which at the version used by
librustls/rustls/aws-lc-rs (0.21.1) produces errors under the pedantic
settings used by rustls-ffi for its examples. The warnings have been
fixed upstream, but not for the version in use by rustls-ffi 0.14.x.
To work around this issue we pass CFLAGS="" when running the make
install for librustls 0.14.1.
commit 681edd0
Author: Daniel McCarney <[email protected]>
Date: Sat Jan 18 10:18:45 2025 -0500
ci: install w/ cargo-c instead of cmake
cmake is only required for the client/server example binaries. For
mod_tls we only need the librustls bits and can use cargo-c directly.
cargo-c respects the host OS pattern of putting libs in an
arch-specific subdir. To make the older 0.14.x Makefile install and the
cargo-c install equivalent we override this behaviour by setting
--libdir.
commit 1f7376a
Author: Daniel McCarney <[email protected]>
Date: Sat Jan 18 10:15:58 2025 -0500
ci: remove stale comment RE: MSRV/cargo-c
The workflow is using the latest cargo-c release, not one tailored to
a Minimum Supported Rust Version (MSRV).
0 commit comments