Improved performance when removing empty lines within <PackageReference> elements

Author: icnocop

src/PackageReferenceVersionToAttribute/ProjectConverter.cs

@@ -106,6 +106,15 @@ private async Task ConvertAsync(string projectFilePath)
                     packageReferenceVersionElement.SetAttributeValue("Version", versionElement.Value);
                     versionElement.Remove();
 
+                    // remove empty child nodes within the <PackageReference>
+                    var childNodes = packageReferenceVersionElement.Nodes()
+                        .OfType<XText>()
+                        .Where(x => string.IsNullOrWhiteSpace(x.Value));
+                    foreach (var node in childNodes)
+                    {
+                        node.Remove();
+                    }
+
                     // Check if the PackageReference is empty and set it to self-closing if so
                     if (!packageReferenceVersionElement.HasElements)
                     {
@@ -138,27 +147,6 @@ private async Task ConvertAsync(string projectFilePath)
                 this.fileService.RemoveReadOnlyAttribute(projectFilePath);
             }
 
-            // remove empty lines within <PackageReference> elements
-            // Select all <PackageReference> elements
-            var packageReferenceElements = document.XPathSelectElements("//PackageReference");
-
-            foreach (var packageReferenceElement in packageReferenceElements)
-            {
-                // Get all the child nodes of the <PackageReference>
-                var childNodes = packageReferenceElement.Nodes();
-
-                // Iterate through the child nodes
-                foreach (var node in childNodes)
-                {
-                    // Check if the node is a text node and contains only whitespace
-                    if (node is XText textNode && string.IsNullOrWhiteSpace(textNode.Value))
-                    {
-                        // Remove the empty line
-                        textNode.Remove();
-                    }
-                }
-            }
-
             var settings = new XmlWriterSettings
             {
                 OmitXmlDeclaration = document.Declaration == null, // Preserve the XML declaration if it exists.