Skip to content

Commit 10a691e

Browse files
committed
Update toggle button logic
1 parent ea4ea01 commit 10a691e

File tree

3 files changed

+16
-11
lines changed

3 files changed

+16
-11
lines changed

Diff for: Assets/Scripts/GUI/MultiplayerRoomOptionsPanelButton.cs

+5
Original file line numberDiff line numberDiff line change
@@ -48,5 +48,10 @@ public void SetToggleState(bool isActive)
4848
m_ToggleActive = isActive;
4949
UpdateVisuals();
5050
}
51+
52+
public bool GetToggleState()
53+
{
54+
return m_ToggleActive;
55+
}
5156
}
5257
} // namespace TiltBrush

Diff for: Assets/Scripts/GUI/MultiplayerRoomOptionsPopUpWindow.cs

+9-9
Original file line numberDiff line numberDiff line change
@@ -178,42 +178,42 @@ public void OnMultiplayerRoomOptionsPopUpWindowButtonPressed(MultiplayerRoomOpti
178178
case SketchControlsScript.GlobalCommands.Null:
179179
break;
180180
case SketchControlsScript.GlobalCommands.ToggleUserVoiceInMultiplayer:
181-
MultiplayerAudioSourcesManager.m_Instance.ToggleAudioMuteForPlayer(button.playerId);
181+
MultiplayerAudioSourcesManager.m_Instance.ToggleAudioMuteForPlayer(button.GetToggleState(), button.playerId);
182182
break;
183183
case SketchControlsScript.GlobalCommands.ToggleUserVoiceInMultiplayerForAll:
184-
MultiplayerManager.m_Instance.MutePlayerForAll(button.IsButtonActive(), button.playerId);
184+
MultiplayerManager.m_Instance.MutePlayerForAll(button.GetToggleState(), button.playerId);
185185
break;
186186
case SketchControlsScript.GlobalCommands.MultiplayerTransferRoomOwnership:
187187
MultiplayerManager.m_Instance.RoomOwnershipTransferToUser(button.playerId);
188188
break;
189189
case SketchControlsScript.GlobalCommands.MultiplayerToggleUserViewEditMode:
190-
MultiplayerManager.m_Instance.ToggleUserViewOnlyMode(button.IsButtonActive(), button.playerId);
190+
MultiplayerManager.m_Instance.ToggleUserViewOnlyMode(button.GetToggleState(), button.playerId);
191191
break;
192192
case SketchControlsScript.GlobalCommands.MultiplayerKickPlayerOut:
193193
MultiplayerManager.m_Instance.KickPlayerOut(button.playerId);
194194
break;
195195
case SketchControlsScript.GlobalCommands.MultiplayerToggleAllUserAudio:
196196
foreach (var remotePlayer in m_RemotePlayers.List)
197197
{
198-
MultiplayerAudioSourcesManager.m_Instance.ToggleAudioMuteForPlayer(remotePlayer.PlayerId);
198+
MultiplayerAudioSourcesManager.m_Instance.ToggleAudioMuteForPlayer(button.GetToggleState(), remotePlayer.PlayerId);
199199
PlayerListItemPrefab playerComponent = GetGameobjectWithPlayerId(remotePlayer.PlayerId);
200-
if (playerComponent) playerComponent.SetAudioToggleState(button.IsButtonActive());
200+
if (playerComponent) playerComponent.SetAudioToggleState(button.GetToggleState());
201201
}
202202
break;
203203
case SketchControlsScript.GlobalCommands.MultiplayerToggleAllUserAudioForAll:
204204
foreach (var remotePlayer in m_RemotePlayers.List)
205205
{
206-
MultiplayerManager.m_Instance.MutePlayerForAll(button.IsButtonActive(), remotePlayer.PlayerId);
206+
MultiplayerManager.m_Instance.MutePlayerForAll(button.GetToggleState(), remotePlayer.PlayerId);
207207
PlayerListItemPrefab playerComponent = GetGameobjectWithPlayerId(remotePlayer.PlayerId);
208-
if (playerComponent) playerComponent.SetAudioForAllToggleState(button.IsButtonActive());
208+
if (playerComponent) playerComponent.SetAudioForAllToggleState(button.GetToggleState());
209209
}
210210
break;
211211
case SketchControlsScript.GlobalCommands.MultiplayerToggleAllUserViewEditMode:
212212
foreach (var remotePlayer in m_RemotePlayers.List)
213213
{
214-
MultiplayerManager.m_Instance.ToggleUserViewOnlyMode(button.IsButtonActive(), remotePlayer.PlayerId);
214+
MultiplayerManager.m_Instance.ToggleUserViewOnlyMode(button.GetToggleState(), remotePlayer.PlayerId);
215215
PlayerListItemPrefab playerComponent = GetGameobjectWithPlayerId(remotePlayer.PlayerId);
216-
if (playerComponent) playerComponent.SetViewOnlyToggleState(button.IsButtonActive());
216+
if (playerComponent) playerComponent.SetViewOnlyToggleState(button.GetToggleState());
217217
}
218218
break;
219219
}

Diff for: Assets/Scripts/Multiplayer/MultiplayerAudioSourcesManager.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,11 @@ public void AudioSourcesMuteStateForPlayer(int playerId, bool state)
9999
source.mute = state;
100100
}
101101

102-
public void ToggleAudioMuteForPlayer(int playerId)
102+
public void ToggleAudioMuteForPlayer(bool state, int playerId)
103103
{
104104
if (sources.TryGetValue(playerId, out AudioSource source))
105105
{
106-
source.mute = !source.mute;
106+
source.mute = state;
107107
}
108108
}
109109
}

0 commit comments

Comments
 (0)