Commit a81cd1d
committed
Merge tri assembly mesh generators and fix detailed mesh regressions
Unify the triangular subchannel/pin mesh generators behind
SCMTriAssemblyMeshGenerator and SCMDetailedTriAssemblyMeshGenerator,
matching the earlier quad-generator merge and the new convention that
assembly generators build both subchannel and pin meshes when pins
exist.
This updates triangular inputs, tests, and registrations to use the new
assembly generator names directly and removes the old tri alias
registrations for consistency with the quad side.
While validating the merged detailed-tri path, fix several regressions:
- stop mutating TriSubChannelMesh from the detailed visualization generator
- avoid post-build renumbering in the detailed-tri assembly path
- copy _pin_nodes in TriSubChannelMesh copy construction
- assign unique element IDs to generated pin prisms by starting from
mesh_base->n_elem()
Also refresh the detailed triangular mesh test baseline to reflect the
new combined subchannel+pin mesh output and quiet its verbose debug
logging. Refs #327961 parent 3b03c31 commit a81cd1d
104 files changed
Lines changed: 540 additions & 1070 deletions
File tree
- modules/subchannel
- doc/content
- modules/subchannel/v&v
- source
- meshgenerators
- positions
- examples
- MultiApp
- duct
- include
- meshgenerators
- mesh
- src
- meshgenerators
- mesh
- test/tests
- SCMTriPower
- gold
- ics
- FCTFdisplacementIC
- marvel
- gold
- tri_flow_area
- gold
- tri_wetted_perimeter
- gold
- mesh
- detailed_quad_assembly
- gold
- detailed_quad_pin_mesh
- gold
- detailed_tri_assembly
- gold
- detailed_tri_pin_mesh
- detailed_tri_sub_channel_mesh/gold
- quad_assembly
- gold
- quad_duct
- gold
- quad_sub_channel_pin_mesh
- gold
- tri_assembly
- gold
- tri_duct
- gold
- tri_sub_channel_pin_mesh
- gold
- tri_subchannel_mesh/gold
- multiapp
- positions
- postprocessors/trisubchannelpointvalue
- problems
- Lead-LBE-19pin
- SFR
- EBR-II
- sodium-19pin
- heat_transfer_correlations
- validation
- Blockage/THORS
- EBR-II
- ORNL_19_pin
- PNNL_12_pin/steady_state
- Toshiba_37_pin
- areva_FCTF
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
| 124 | + | |
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
| 124 | + | |
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| |||
Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
Lines changed: 0 additions & 17 deletions
This file was deleted.
Lines changed: 0 additions & 21 deletions
This file was deleted.
Lines changed: 21 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
Lines changed: 0 additions & 22 deletions
This file was deleted.
Lines changed: 0 additions & 24 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | 43 | | |
55 | 44 | | |
56 | 45 | | |
| |||
0 commit comments