Skip to content

New UserObjectInterface updates broke a few Cardinal getuserobject() calls #134

@meltawila

Description

@meltawila

Bug Description

SALAMANDER build currently fails with the error below due to recent UserObjectInterface update in idaholab/moose#32755. I added a fix in neams-th-coe/cardinal#1328 and will update the Cardinal submodule once it's merged

In file included from /tmp/build/salamander/cardinal/build/unity_src/auxkernels_Unity.C:13:
/tmp/build/salamander/cardinal/src/auxkernels/HeatTransferCoefficientAux.C: In constructor 'HeatTransferCoefficientAux::HeatTransferCoefficientAux(const InputParameters&)':
/tmp/build/salamander/cardinal/src/auxkernels/HeatTransferCoefficientAux.C:40:33: error: invalid initialization of reference of type 'const UserObject&' from expression of type 'const UserObjectBase'
   40 |     _heat_flux(getUserObjectBase("heat_flux")),
      |                ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
/tmp/build/salamander/cardinal/src/auxkernels/HeatTransferCoefficientAux.C:41:30: error: invalid initialization of reference of type 'const UserObject&' from expression of type 'const UserObjectBase'
   41 |     _wall_T(getUserObjectBase("wall_T")),
      |             ~~~~~~~~~~~~~~~~~^~~~~~~~~~
/tmp/build/salamander/cardinal/src/auxkernels/HeatTransferCoefficientAux.C:42:30: error: invalid initialization of reference of type 'const UserObject&' from expression of type 'const UserObjectBase'
   42 |     _bulk_T(getUserObjectBase("bulk_T"))
      |             ~~~~~~~~~~~~~~~~~^~~~~~~~~~
In file included from /tmp/build/salamander/cardinal/build/unity_src/auxkernels_Unity.C:17:
/tmp/build/salamander/cardinal/src/auxkernels/SkinnedBins.C: In constructor 'SkinnedBins::SkinnedBins(const InputParameters&)':
/tmp/build/salamander/cardinal/src/auxkernels/SkinnedBins.C:41:46: error: invalid initialization of reference of type 'const UserObject&' from expression of type 'const UserObjectBase'
   41 |   const UserObject & base = getUserObjectBase("skinner");
      |                             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~
Compiling C++ (in opt mode) /tmp/build/salamander/cardinal/build/unity_src/actions_Unity.C...
Compiling C++ (in opt mode) /tmp/build/salamander/cardinal/build/unity_src/timesteppers_Unity.C...
Compiling C++ (in opt mode) /tmp/build/salamander/cardinal/build/unity_src/filters_Unity.C...
Compiling C++ (in opt mode) /tmp/build/salamander/cardinal/build/unity_src/parser_Unity.C...
make: *** [/tmp/build/salamander/moose/framework/build.mk:166: /tmp/build/salamander/cardinal/build/unity_src/auxkernels_Unity.x86_64-pc-linux-gnu.opt.lo] Error 1
make: *** Waiting for unfinished jobs....
[03:34:09] ERROR: Exiting with code 2

Steps to Reproduce

Error appears on Civet and I could reproduce it locally

Impact

prevents building SALAMANDER

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions