[#9] Add e2e tests for article read #15
Merged
Merged
Conversation
Closed
There was a problem hiding this comment.
Pull request overview
Adds Playwright E2E coverage for the “article read” feature and refactors existing article tests/utilities to use new @article/* path aliases and updated article payload models.
Changes:
- Introduces new
Article - ReadE2E specs plus supporting fixtures/page objects/components. - Refactors article creation tests to use
CreateArticleRequest(body,tagList) and new fixtures under@article/fixtures/*. - Adds new shared utilities/pages (e.g.,
HomePage, date formatting) and extends API/front URL helpers for article list & tags.
Reviewed changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Adds @article/* path alias for E2E tests. |
| e2e/tests/auth/specifications/login.spec.ts | Switches to alias-based fixture import. |
| e2e/tests/auth/auth.utility.ts | Adds helper to mint auth tokens per test/shard/worker. |
| e2e/tests/article/specifications/article-read.spec.ts | New E2E coverage for listing, pagination, tag filtering, and negative/edge cases. |
| e2e/tests/article/specifications/article-creation.spec.ts | Updates to new article payload model + new fixtures/import paths. |
| e2e/tests/article/pages/article-editor.page.ts | Updates typing to CreateArticleRequest and rewires imports. |
| e2e/tests/article/pages/article-details.page.ts | Adds URL navigation helper and updates assertions for new model (body, tagList). |
| e2e/tests/article/models/article.model.ts | Expands Article and introduces CreateArticleRequest. |
| e2e/tests/article/fixtures/article-read.fixture.ts | New fixture providing token, payload, and page objects for article read tests. |
| e2e/tests/article/fixtures/article-creation.fixture.ts | New fixture replacing old article.fixture.ts. |
| e2e/tests/article/components/article-preview.component.ts | New component assertions for article preview rows. |
| e2e/tests/article/components/article-form.component.ts | New component for editor form interactions/assertions. |
| e2e/tests/article/article.utility.ts | Adds API helpers and mocks for article list and tag list. |
| e2e/shared/utilities/url-front.utility.ts | Adds front URL constants for article details and profile. |
| e2e/shared/utilities/url-api.utility.ts | Adds API URL helpers for article list pagination and tags list. |
| e2e/shared/utilities/date.utilities.ts | New date formatting utility used by preview assertions. |
| e2e/shared/pages/home.page.ts | New Home page object used by article read tests. |
| e2e/shared/layouts/header.component.ts | Adds authenticated-header visibility assertion helper. |
| docs/tests-inventories/0002_article-inventory.xlsx | Adds/updates test inventory documentation artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Refs: #9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Does this close any currently open issues?
Any other comments?
None.
I'm not a dummy, so I've checked these