Skip to content

Commit cef733d

Browse files
dderuntzclaude
andcommitted
cc-firmware workflow: drop --build-property, rely on build_opt.h
The --build-property 'build.extra_flags=-DUSB_PRODUCT="Duck Duck Duck"' flag was getting split on the spaces in the value, producing 'cannot specify -o with -c with multiple files' from xtensa-g++. Each sketch already has a build_opt.h alongside it that defines the same USB descriptor flags; arduino-cli picks that up natively. Net behavior unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 197b25e commit cef733d

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/cc-firmware-release.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,16 @@ jobs:
6969
# PSRAM=opi for the WROOM-1 (ducky PCB) — XIAO Sense's S3 also
7070
# has PSRAM enabled in its default partition. PartitionScheme
7171
# default_8MB to match the 8MB flash on both boards.
72+
#
73+
# USB manufacturer/product descriptor flags come from each
74+
# sketch's build_opt.h — arduino-cli picks that up natively
75+
# since v0.21. We don't pass --build-property here because
76+
# the spaces in "Duck Duck Duck" don't survive bash quoting
77+
# cleanly through to the gcc command line.
7278
run: |
7379
arduino-cli compile \
7480
--fqbn 'esp32:esp32:esp32s3:USBMode=hwcdc,CDCOnBoot=cdc,PartitionScheme=default_8MB,FlashSize=8M,PSRAM=opi' \
7581
--output-dir build_${{ matrix.variant }} \
76-
--build-property 'build.extra_flags=-DUSB_MANUFACTURER="IDEO" -DUSB_PRODUCT="Duck Duck Duck"' \
7782
${{ matrix.sketch_dir }}
7883
7984
- name: Merge into single flashable image

0 commit comments

Comments
 (0)