Skip to content

Commit 60ad228

Browse files
Rename dialogId and dialogIdParent to id and parentId for consistency across Dialog class and related modules
1 parent 8dd47d3 commit 60ad228

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/sdialog/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,8 @@ class Dialog(BaseModel):
106106
formatVersion: Optional[str] = Field(default_factory=_get_dynamic_version) # Version of the format
107107
model: Optional[str] = None # the model used to generate the dialogue
108108
seed: Optional[int] = None # the seed used to generated
109-
dialogId: Optional[int] = None # Unique ID for the dialogue
110-
dialogIdParent: Optional[int] = None # ID of the parent dialogue, if any
109+
id: Optional[int] = None # Unique ID for the dialogue
110+
parentId: Optional[int] = None # ID of the parent dialogue, if any
111111
complete: Optional[bool] = None
112112
personas: Optional[dict[str, dict[str, Any]]] = None # personas used in the dialogue
113113
scenario: Optional[Union[dict, str]] = None # the scenario used to generated the dialogue
@@ -286,8 +286,8 @@ def _print_dialog(dialog: Union[Dialog, dict], scenario: bool = False, orchestra
286286
speaker_utt_colors = ["grey", "white"]
287287
# speaker_utt_colors = ["black", "grey"]
288288

289-
if dialog.dialogId:
290-
print(dialog.dialogId, tag="dialog_id", tag_color="purple", color="magenta", format="bold")
289+
if dialog.id:
290+
print(dialog.id, tag="dialog_id", tag_color="purple", color="magenta", format="bold")
291291
if dialog.complete:
292292
print(dialog.complete, tag="complete", tag_color="purple", color="magenta", format="bold")
293293
if dialog.model:

src/sdialog/datasets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def get_dialog(id):
9595
e["Agent"] = "System"
9696

9797
return Dialog(
98-
dialogId=id,
98+
id=id,
9999
scenario=dialog["Scenario"],
100100
turns=[Turn(speaker=e["Agent"], text=e["Text"])
101101
for e in dialog["Events"]

src/sdialog/generators.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ def generate(self, seed: int = None, id: int = None, parent_id: int = None, note
123123
llm_output = self.output_format.model_validate(json.loads(dialogue))
124124

125125
if self.output_format is LLMDialogOutput:
126-
return Dialog(dialogId=id if id else None,
127-
dialogIdParent=parent_id,
126+
return Dialog(id=id if id else None,
127+
parentId=parent_id,
128128
model=self.model_name,
129129
seed=self.llm.seed,
130130
personas=self._personas,

src/sdialog/personas.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -646,8 +646,8 @@ def dialog_with(self,
646646
}
647647

648648
return Dialog(
649-
dialogId=id if id else None,
650-
dialogIdParent=parent_id,
649+
id=id if id else None,
650+
parentId=parent_id,
651651
complete=completion, # incomplete if ran out of iterations (reached max_iteration number)
652652
model=self.model_name,
653653
seed=seed,

0 commit comments

Comments
 (0)