fix(dynamic-length): send the last chunk of dynamic length

Author: ido-pluto

src/download/download-engine/streams/download-engine-fetch-stream/download-engine-fetch-stream-fetch.ts

@@ -139,6 +139,8 @@ export default class DownloadEngineFetchStreamFetch extends BaseDownloadEngineFe
             smartSplit.addChunk(chunkInfo.value);
             this.state.onProgress?.(smartSplit.savedLength);
         }
+
+        smartSplit.closeAndSendLeftoversIfLengthIsUnknown();
     }
 
     protected _wrapperStreamNotResponding<T>(promise: Promise<T> | T): Promise<T | void> | T | void {

src/download/download-engine/streams/download-engine-fetch-stream/utils/smart-chunk-split.ts

@@ -14,6 +14,7 @@ export default class SmartChunkSplit {
     private readonly _lastChunkSize: number;
     private _bytesWriteLocation: number;
     private _chunks: Uint8Array[] = [];
+    private _closed = false;
 
     public constructor(_callback: WriteCallback, _options: SmartChunkSplitOptions) {
         this._options = _options;
@@ -36,7 +37,16 @@ export default class SmartChunkSplit {
         return this._chunks.reduce((acc, chunk) => acc + chunk.length, 0);
     }
 
+    closeAndSendLeftoversIfLengthIsUnknown() {
+        if (this._chunks.length > 0 && this._options.endChunk === Infinity) {
+            this._callback(this._chunks, this._bytesWriteLocation, this._options.startChunk++);
+        }
+        this._closed = true;
+    }
+
     private _sendChunk() {
+        if (this._closed) return;
+
         const checkThreshold = () =>
             (this._options.endChunk - this._options.startChunk === 1 ?
                 this._lastChunkSize : this._options.chunkSize);

src/download/download-engine/streams/download-engine-fetch-stream/utils/stream-response.ts

@@ -20,7 +20,7 @@ export default async function streamResponse(stream: IStreamResponse, downloadEn
     });
 
     stream.on("close", () => {
-        smartSplit.sendLeftovers();
+        smartSplit.closeAndSendLeftoversIfLengthIsUnknown();
         resolve();
     });
 

test/daynamic-content-length.test.ts

@@ -28,7 +28,11 @@ describe("Dynamic content download", async () => {
         const downloader = await downloadFile({
             url: DYNAMIC_DOWNLOAD_FILE,
             directory: ".",
-            fileName: IPUll_FILE
+            fileName: IPUll_FILE,
+            defaultFetchDownloadInfo: {
+                acceptRange: false,
+                length: 0
+            }
         });
 
         await downloader.download();
@@ -41,7 +45,11 @@ describe("Dynamic content download", async () => {
 
     test.concurrent("Browser Download", async (context) => {
         const downloader = await downloadFileBrowser({
-            url: DYNAMIC_DOWNLOAD_FILE
+            url: DYNAMIC_DOWNLOAD_FILE,
+            defaultFetchDownloadInfo: {
+                acceptRange: false,
+                length: 0
+            }
         });
 
         await downloader.download();