fix(close-download): small files race conditions

ido-pluto · ido-pluto · commit 39e7a8730005 · 2025-07-08T22:16:37.000+03:00
diff --git a/src/download/download-engine/download-file/download-engine-file.ts b/src/download/download-engine/download-file/download-engine-file.ts
@@ -409,9 +409,9 @@ export default class DownloadEngineFile extends EventEmitter<DownloadEngineFileE
         }
         this._closed = true;
         this._activeProgram?.abort();
-        await this.options.onCloseAsync?.();
         await this.options.writeStream.close();
         await this.options.fetchStream.close();
+        await this.options.onCloseAsync?.();
         this.emit("closed");
     }
 

Original file line number	Diff line number	Diff line change
`@@ -409,9 +409,9 @@ export default class DownloadEngineFile extends EventEmitter<DownloadEngineFileE`
`409`	`409`	`}`
`410`	`410`	`this._closed = true;`
`411`	`411`	`this._activeProgram?.abort();`
`412`		`- await this.options.onCloseAsync?.();`
`413`	`412`	`await this.options.writeStream.close();`
`414`	`413`	`await this.options.fetchStream.close();`
	`414`	`+ await this.options.onCloseAsync?.();`
`415`	`415`	`this.emit("closed");`
`416`	`416`	`}`
`417`	`417`