Skip to content

Commit 1bc5549

Browse files
author
ID Bot
committed
Script updating archive at 2025-08-12T02:09:09Z. [ci skip]
1 parent 4b1bb11 commit 1bc5549

1 file changed

Lines changed: 68 additions & 1 deletion

File tree

archive.json

Lines changed: 68 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"magic": "E!vIA5L86J2I",
3-
"timestamp": "2025-08-10T02:31:34.503585+00:00",
3+
"timestamp": "2025-08-12T02:09:07.747492+00:00",
44
"repo": "davidben/merkle-tree-certs",
55
"labels": [
66
{
@@ -6516,6 +6516,73 @@
65166516
"comments": []
65176517
}
65186518
]
6519+
},
6520+
{
6521+
"number": 120,
6522+
"id": "PR_kwDOJIBkVc6jISOk",
6523+
"title": "Fix typo in definition of k for subtree proofs",
6524+
"url": "https://github.com/davidben/merkle-tree-certs/pull/120",
6525+
"state": "OPEN",
6526+
"author": "lukevalenta",
6527+
"authorAssociation": "CONTRIBUTOR",
6528+
"assignees": [],
6529+
"labels": [],
6530+
"body": "",
6531+
"createdAt": "2025-08-11T20:39:06Z",
6532+
"updatedAt": "2025-08-12T00:40:54Z",
6533+
"baseRepository": "davidben/merkle-tree-certs",
6534+
"baseRefName": "main",
6535+
"baseRefOid": "1dac3dab0c7000815be761d56a1a10c4276b5f0a",
6536+
"headRepository": "lukevalenta/merkle-tree-certs",
6537+
"headRefName": "patch-1",
6538+
"headRefOid": "8cef491504d25a8f7dcd195f2a7339ff7c19bcbf",
6539+
"closedAt": null,
6540+
"mergedAt": null,
6541+
"mergedBy": null,
6542+
"mergeCommit": null,
6543+
"comments": [],
6544+
"reviews": [
6545+
{
6546+
"id": "PRR_kwDOJIBkVc65Qad1",
6547+
"commit": {
6548+
"abbreviatedOid": "407db51"
6549+
},
6550+
"author": "davidben",
6551+
"authorAssociation": "OWNER",
6552+
"state": "COMMENTED",
6553+
"body": "",
6554+
"createdAt": "2025-08-11T23:51:58Z",
6555+
"updatedAt": "2025-08-11T23:51:58Z",
6556+
"comments": [
6557+
{
6558+
"originalPosition": 5,
6559+
"body": "Hmm. I think greater is correct, unless I'm confused? `[2, 5)` is not a valid subtree because it makes this tree:\r\n\r\n```\r\n /\\\r\n /\\ |\r\n2 3 4\r\n```\r\n\r\nBut then `[0, 5)` looks like this, which doesn't contain that tree:\r\n\r\n```\r\n /\\\r\n / \\\r\n /\\ |\r\n / \\ |\r\n /\\ /\\ |\r\n0 1 2 3 4\r\n```\r\n\r\nSo if the subtree has size 3, we need start to be 4-aligned, not just 2-aligned.\r\n\r\nBut in that case \"largest power of 2\" should be \"smallest power of 2\".",
6560+
"createdAt": "2025-08-11T23:51:58Z",
6561+
"updatedAt": "2025-08-11T23:51:58Z"
6562+
}
6563+
]
6564+
},
6565+
{
6566+
"id": "PRR_kwDOJIBkVc65QnuS",
6567+
"commit": {
6568+
"abbreviatedOid": "407db51"
6569+
},
6570+
"author": "lukevalenta",
6571+
"authorAssociation": "CONTRIBUTOR",
6572+
"state": "COMMENTED",
6573+
"body": "",
6574+
"createdAt": "2025-08-12T00:31:10Z",
6575+
"updatedAt": "2025-08-12T00:31:10Z",
6576+
"comments": [
6577+
{
6578+
"originalPosition": 5,
6579+
"body": "Ah yes, you're right--thanks for the catch and the counterexample! I agree the correct version is \"If `k` is the smallest power of 2 that is greater than or equal to `end - start`, `start` must be a multiple of `k`\", since for any size subtree we want the start index to be aligned with the next-greatest power of two.\r\n\r\nI got confused since [RFC9162](https://datatracker.ietf.org/doc/html/rfc9162#section-2.1.1) and [the subtree consistency proof section](https://www.ietf.org/archive/id/draft-davidben-tls-merkle-tree-certs-06.html#section-4.3.1) say \"let k be the largest power of two smaller than n\", but we're dealing with a different `k` here--that `k` is for a split index, but the `k` here is a restriction on the subtree start index. Maybe we pick a new letter like `s` for \"start\"?",
6580+
"createdAt": "2025-08-12T00:31:10Z",
6581+
"updatedAt": "2025-08-12T00:31:10Z"
6582+
}
6583+
]
6584+
}
6585+
]
65196586
}
65206587
]
65216588
}

0 commit comments

Comments
 (0)