Skip to content

Commit 2cc7acd

Browse files
author
ID Bot
committed
Script updating archive at 2025-09-18T01:53:25Z. [ci skip]
1 parent 7460646 commit 2cc7acd

1 file changed

Lines changed: 145 additions & 1 deletion

File tree

‎archive.json‎

Lines changed: 145 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"magic": "E!vIA5L86J2I",
3-
"timestamp": "2025-09-16T01:53:30.416699+00:00",
3+
"timestamp": "2025-09-18T01:53:22.856727+00:00",
44
"repo": "davidben/merkle-tree-certs",
55
"labels": [
66
{
@@ -8499,6 +8499,150 @@
84998499
]
85008500
}
85018501
]
8502+
},
8503+
{
8504+
"number": 144,
8505+
"id": "PR_kwDOJIBkVc6o7Pao",
8506+
"title": "Clarify verification process",
8507+
"url": "https://github.com/davidben/merkle-tree-certs/pull/144",
8508+
"state": "MERGED",
8509+
"author": "davidben",
8510+
"authorAssociation": "OWNER",
8511+
"assignees": [],
8512+
"labels": [],
8513+
"body": "Matt Mueller noticed that the process was ambiguous about where the MTCProof fields came from, and that we didn't consistently rename the OID to match the id-alg-* convention that LAMPS seems to be using these days.\r\n\r\nFrom there I also noticed that the shape of RFC 9162, section 2.1.3.2 doesn't quite fit what we need. We want to run the inclusion proof, get the expected subtree hash, and then check a signature over it. RFC 9162 assumes you already know the subtree hash and are just checking it. I copy-pasted the description from RFC 9162 and inlined the small changes we were making.",
8514+
"createdAt": "2025-09-16T19:15:01Z",
8515+
"updatedAt": "2025-09-17T14:31:35Z",
8516+
"baseRepository": "davidben/merkle-tree-certs",
8517+
"baseRefName": "main",
8518+
"baseRefOid": "a3438ec54667d3a562edc0b905e41e35951a176c",
8519+
"headRepository": "davidben/merkle-tree-certs",
8520+
"headRefName": "clarify-verification",
8521+
"headRefOid": "df21aa784d32ab4f86f13950bfbf19c4909c4d07",
8522+
"closedAt": "2025-09-17T14:21:47Z",
8523+
"mergedAt": "2025-09-17T14:21:47Z",
8524+
"mergedBy": "davidben",
8525+
"mergeCommit": {
8526+
"oid": "7d0cadd3925a67ce9d0c34efa26261f2ed95eb90"
8527+
},
8528+
"comments": [],
8529+
"reviews": [
8530+
{
8531+
"id": "PRR_kwDOJIBkVc7AmqJp",
8532+
"commit": {
8533+
"abbreviatedOid": "18d138a"
8534+
},
8535+
"author": "davidben",
8536+
"authorAssociation": "OWNER",
8537+
"state": "COMMENTED",
8538+
"body": "",
8539+
"createdAt": "2025-09-16T19:19:36Z",
8540+
"updatedAt": "2025-09-16T19:19:37Z",
8541+
"comments": [
8542+
{
8543+
"originalPosition": 65,
8544+
"body": "This is implicit in subtree evaluation now.",
8545+
"createdAt": "2025-09-16T19:19:37Z",
8546+
"updatedAt": "2025-09-16T19:19:37Z"
8547+
}
8548+
]
8549+
},
8550+
{
8551+
"id": "PRR_kwDOJIBkVc7AvG2j",
8552+
"commit": {
8553+
"abbreviatedOid": "df21aa7"
8554+
},
8555+
"author": "bwesterb",
8556+
"authorAssociation": "COLLABORATOR",
8557+
"state": "APPROVED",
8558+
"body": "",
8559+
"createdAt": "2025-09-17T09:42:33Z",
8560+
"updatedAt": "2025-09-17T09:42:33Z",
8561+
"comments": []
8562+
},
8563+
{
8564+
"id": "PRR_kwDOJIBkVc7AzrcA",
8565+
"commit": {
8566+
"abbreviatedOid": "df21aa7"
8567+
},
8568+
"author": "lukevalenta",
8569+
"authorAssociation": "COLLABORATOR",
8570+
"state": "COMMENTED",
8571+
"body": "",
8572+
"createdAt": "2025-09-17T14:28:07Z",
8573+
"updatedAt": "2025-09-17T14:28:08Z",
8574+
"comments": [
8575+
{
8576+
"originalPosition": 25,
8577+
"body": "I think this is another case where it will never terminate due to the \"`fn` is 0\" condition.\r\n```suggestion\r\n 1. Until LSB(fn) is set, right-shift both `fn` and `sn` equally.\r\n```",
8578+
"createdAt": "2025-09-17T14:28:08Z",
8579+
"updatedAt": "2025-09-17T14:28:08Z"
8580+
}
8581+
]
8582+
},
8583+
{
8584+
"id": "PRR_kwDOJIBkVc7Azvak",
8585+
"commit": {
8586+
"abbreviatedOid": "df21aa7"
8587+
},
8588+
"author": "lukevalenta",
8589+
"authorAssociation": "COLLABORATOR",
8590+
"state": "COMMENTED",
8591+
"body": "",
8592+
"createdAt": "2025-09-17T14:31:35Z",
8593+
"updatedAt": "2025-09-17T14:31:35Z",
8594+
"comments": [
8595+
{
8596+
"originalPosition": 25,
8597+
"body": "(I made a new PR: https://github.com/davidben/merkle-tree-certs/pull/145)",
8598+
"createdAt": "2025-09-17T14:31:35Z",
8599+
"updatedAt": "2025-09-17T14:38:12Z"
8600+
}
8601+
]
8602+
}
8603+
]
8604+
},
8605+
{
8606+
"number": 145,
8607+
"id": "PR_kwDOJIBkVc6pF5KJ",
8608+
"title": "Clarify loop exit condition in subtree inclusion proof verification",
8609+
"url": "https://github.com/davidben/merkle-tree-certs/pull/145",
8610+
"state": "MERGED",
8611+
"author": "lukevalenta",
8612+
"authorAssociation": "COLLABORATOR",
8613+
"assignees": [],
8614+
"labels": [],
8615+
"body": "Entering the loop, either `LSB(fn)` is already set, or `fn` is equal to `sn` which is non-zero. Thus, the right-shifting loop will only ever exit due to `LSB(fn)` being set.",
8616+
"createdAt": "2025-09-17T14:37:23Z",
8617+
"updatedAt": "2025-09-17T15:00:07Z",
8618+
"baseRepository": "davidben/merkle-tree-certs",
8619+
"baseRefName": "main",
8620+
"baseRefOid": "7d0cadd3925a67ce9d0c34efa26261f2ed95eb90",
8621+
"headRepository": "davidben/merkle-tree-certs",
8622+
"headRefName": "lukevalenta-patch-1",
8623+
"headRefOid": "891a74a1fb707e7bda88ed955ea18c8ad61a05b7",
8624+
"closedAt": "2025-09-17T15:00:02Z",
8625+
"mergedAt": "2025-09-17T15:00:02Z",
8626+
"mergedBy": "davidben",
8627+
"mergeCommit": {
8628+
"oid": "0012b785843b8449011fd2402db236309e09105f"
8629+
},
8630+
"comments": [],
8631+
"reviews": [
8632+
{
8633+
"id": "PRR_kwDOJIBkVc7A0Q00",
8634+
"commit": {
8635+
"abbreviatedOid": "891a74a"
8636+
},
8637+
"author": "davidben",
8638+
"authorAssociation": "OWNER",
8639+
"state": "APPROVED",
8640+
"body": "I considered suggesting we add an explanatory sentence to \u201cThis is the same as the procedure [\u2026]\u201d because it\u2019s now not as obvious, but it seemed awkward so\u2026 meh.",
8641+
"createdAt": "2025-09-17T14:59:54Z",
8642+
"updatedAt": "2025-09-17T14:59:54Z",
8643+
"comments": []
8644+
}
8645+
]
85028646
}
85038647
]
85048648
}

0 commit comments

Comments
 (0)