Skip to content

Commit 5852d4b

Browse files
author
ID Bot
committed
Script updating archive at 2025-10-12T02:02:48Z. [ci skip]
1 parent 76efb01 commit 5852d4b

1 file changed

Lines changed: 64 additions & 2 deletions

File tree

archive.json

Lines changed: 64 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"magic": "E!vIA5L86J2I",
3-
"timestamp": "2025-10-07T01:54:52.698811+00:00",
3+
"timestamp": "2025-10-12T02:02:46.519827+00:00",
44
"repo": "davidben/merkle-tree-certs",
55
"labels": [
66
{
@@ -8869,7 +8869,7 @@
88698869
"labels": [],
88708870
"body": "CC @nharper\r\n \r\nCloses #147",
88718871
"createdAt": "2025-10-06T16:34:12Z",
8872-
"updatedAt": "2025-10-06T22:27:44Z",
8872+
"updatedAt": "2025-10-10T23:24:11Z",
88738873
"baseRepository": "davidben/merkle-tree-certs",
88748874
"baseRefName": "main",
88758875
"baseRefOid": "ddafe7889a99a477a99e2eb0a9da1fe555b58a27",
@@ -8901,6 +8901,68 @@
89018901
"updatedAt": "2025-10-06T16:34:50Z"
89028902
}
89038903
]
8904+
},
8905+
{
8906+
"id": "PRR_kwDOJIBkVc7GPMSR",
8907+
"commit": {
8908+
"abbreviatedOid": "3ffb3a1"
8909+
},
8910+
"author": "nharper",
8911+
"authorAssociation": "NONE",
8912+
"state": "COMMENTED",
8913+
"body": "Some suggestions and questions, and I need to keep reading.",
8914+
"createdAt": "2025-10-10T20:40:40Z",
8915+
"updatedAt": "2025-10-10T23:24:11Z",
8916+
"comments": [
8917+
{
8918+
"originalPosition": 128,
8919+
"body": "\"the condition in step 4.2 is always tree\": should that be \"is always true\" instead of \"is always tree\"?",
8920+
"createdAt": "2025-10-10T20:40:40Z",
8921+
"updatedAt": "2025-10-10T23:24:11Z"
8922+
},
8923+
{
8924+
"originalPosition": 122,
8925+
"body": "Possibly add:\r\n\r\n> `fn` has the bit pattern that tracks the path from `index` to the root of the subtree, and `sn` has the bit pattern that that tracks the right edge of the subtree.",
8926+
"createdAt": "2025-10-10T20:42:58Z",
8927+
"updatedAt": "2025-10-10T23:24:11Z"
8928+
},
8929+
{
8930+
"originalPosition": 124,
8931+
"body": "Possibly add:\r\n\r\n> Since `sn` tracks the path of the right edge to the root of the subtree, the last direction in this path will always be right, which is a 1 bit, hence `sn` is non-zero exactly when there are additional levels to traverse.",
8932+
"createdAt": "2025-10-10T20:50:16Z",
8933+
"updatedAt": "2025-10-10T23:24:11Z"
8934+
},
8935+
{
8936+
"originalPosition": 62,
8937+
"body": "Nit: should this have `{#binary-representations}` so that if the heading gets renamed, the xref from below will still be correct?",
8938+
"createdAt": "2025-10-10T20:52:13Z",
8939+
"updatedAt": "2025-10-10T23:24:11Z"
8940+
},
8941+
{
8942+
"originalPosition": 132,
8943+
"body": "Something that helped me understand this better was when you told me that `fn`, `sn`, and `tn` stand for \"first number\", \"second number\", and \"third number\". Perhaps that would be useful for others and could be mentioned in this section. I think `r` means \"running hash\"?\r\n\r\n(EDIT 1: Out of scope for this PR, but the naming of `fr` and `sr` implies some correlation between those and `fn` and `sn`. In RFC 9162 2.1.4.2, there is no `tn`, and there is direct correlation between the inputs `first`, `first_hash` and variables `fn` and `fr` (same for `second`, `second_hash`, `sn`, and `sr`). In this MTC draft, the variables `fr` and `sr` seem more closely correlated with `sn` and `tn` than they do with `fn` and `sn`, which makes me think those variables should be renamed. Maybe `sr` and `tr`? Maybe `nh` (node hash) and `rh` (root hash)?)\r\n\r\nEDIT 2 (also out of scope for this PR): Both verification procedures follow the same pattern: initialize some variables, then loop over the proof array and incorporate hashes. Could the variables be renamed so that `fn` and `r` in the inclusion proof procedure have the same names as `sn` and `sr` in the consistency proof procedure? AFAICT, once we're in the loop, those are performing the exact same steps (though the initialization is different). (While we're there, maybe give the same name to `p` in the inclusion proof procedure as `c` in the consistency proof procedure? I'm assuming `p` means \"proof\" and `c` means \"consistency proof\", which isn't consistent.)",
8944+
"createdAt": "2025-10-10T21:06:27Z",
8945+
"updatedAt": "2025-10-10T23:24:11Z"
8946+
},
8947+
{
8948+
"originalPosition": 148,
8949+
"body": "\"From there, step 6 incorporates the consistency proof ...\" Step 6 was initializing `fr` and `sr`, and is described above. I think that sentence is supposed to say \"step 7\" instead of \"step 6\", or I'm misunderstanding something in the verification or this explanation.",
8950+
"createdAt": "2025-10-10T22:28:17Z",
8951+
"updatedAt": "2025-10-10T23:24:11Z"
8952+
},
8953+
{
8954+
"originalPosition": 136,
8955+
"body": "I think something is missing from this description, but I haven't figured it out yet. I'll take another look next week.",
8956+
"createdAt": "2025-10-10T23:21:59Z",
8957+
"updatedAt": "2025-10-10T23:24:11Z"
8958+
},
8959+
{
8960+
"originalPosition": 151,
8961+
"body": "I'm getting a bit of \"and then draw the rest of the owl\" vibes from this. I'll take another look on Monday to see if I can offer a suggestion on more words here.",
8962+
"createdAt": "2025-10-10T23:22:20Z",
8963+
"updatedAt": "2025-10-10T23:24:11Z"
8964+
}
8965+
]
89048966
}
89058967
]
89068968
},

0 commit comments

Comments
 (0)