Skip to content

Commit 67d280a

Browse files
committed
estimate_tile_size: Rename old/new to CT and MTC
Makes the output a bit clearer.
1 parent 923c83b commit 67d280a

1 file changed

Lines changed: 23 additions & 23 deletions

File tree

estimate_tile_size.go

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -304,8 +304,8 @@ func do() error {
304304
fmt.Printf("Sampling from log %s\n", *flagURL)
305305
fmt.Printf("Filtering AIA in simulated MTC tiles: %t\n", *flagFilterAIA)
306306
fmt.Printf("Filtering SKID/AKID in simulated MTC tiles: %t\n", *flagFilterKeyIDs)
307-
fmt.Printf("Simulating PQ with %s\n", *flagPQAlg)
308-
fmt.Printf("Including embedded SCTs in PQ simulation: %t\n", *flagPQEmbeddedSCTs)
307+
fmt.Printf("Simulating PQ CT tiles with %s\n", *flagPQAlg)
308+
fmt.Printf("Including embedded SCTs in PQ CT simulation: %t\n", *flagPQEmbeddedSCTs)
309309
fmt.Printf("\n")
310310

311311
treeSize, err := fetchTreeSize(baseURL)
@@ -314,9 +314,9 @@ func do() error {
314314
}
315315
fmt.Printf("Tree size: %d\n", treeSize)
316316

317-
oldStats := tileStats{name: "old"}
318-
newStats := tileStats{name: "new"}
319-
oldPQStats := tileStats{name: "old + PQ"}
317+
ctStats := tileStats{name: "CT"}
318+
mtcStats := tileStats{name: "MTC"}
319+
pqCTStats := tileStats{name: "PQ CT"}
320320

321321
for range *flagSamples {
322322
numFullTiles := treeSize / fullTileSize
@@ -330,8 +330,8 @@ func do() error {
330330
return err
331331
}
332332
// For a fair comparison, redo the gzip rather than reuse the original
333-
// log's gzip, so that old and new tiles have the same gzip settings.
334-
oldGzipSize := gzipSize(tile)
333+
// log's gzip, so that CT and MTC tiles have the same gzip settings.
334+
ctGzipSize := gzipSize(tile)
335335

336336
certs, err := parseDataTile(tile, tileSize)
337337
if err != nil {
@@ -355,35 +355,35 @@ func do() error {
355355
pqIncrease += scts.numSCTs*pqAlg.signatureSize - scts.totSig
356356
}
357357

358-
// Construct the new tiles.
358+
// Construct the MTC tiles.
359359
entry := tbsCertLogEntryFromCert(cert)
360360
b.AddUint16LengthPrefixed(func(child *cryptobyte.Builder) {
361361
child.AddBytes(entry)
362362
})
363363
}
364-
newTile := b.BytesOrPanic()
365-
newGzipSize := gzipSize(newTile)
364+
mtcTile := b.BytesOrPanic()
365+
mtcGzipSize := gzipSize(mtcTile)
366366

367-
oldStats.tot += len(tile)
368-
oldStats.gzipTot += oldGzipSize
367+
ctStats.tot += len(tile)
368+
ctStats.gzipTot += ctGzipSize
369369
// Assume that keys and signatures are incompressible, so just add it to
370370
// the gzip sizes.
371-
oldPQStats.tot += len(tile) + pqIncrease
372-
oldPQStats.gzipTot += oldGzipSize + pqIncrease
373-
newStats.tot += len(newTile)
374-
newStats.gzipTot += newGzipSize
371+
pqCTStats.tot += len(tile) + pqIncrease
372+
pqCTStats.gzipTot += ctGzipSize + pqIncrease
373+
mtcStats.tot += len(mtcTile)
374+
mtcStats.gzipTot += mtcGzipSize
375375
}
376376

377377
fmt.Printf("\n")
378-
printAvg(oldStats)
379-
printAvg(oldPQStats)
380-
printAvg(newStats)
378+
printAvg(ctStats)
379+
printAvg(pqCTStats)
380+
printAvg(mtcStats)
381381
fmt.Printf("\n")
382-
compareStats(oldPQStats, oldStats)
383-
compareStats(newStats, oldStats)
384-
compareStats(newStats, oldPQStats)
382+
compareStats(pqCTStats, ctStats)
383+
compareStats(mtcStats, ctStats)
384+
compareStats(mtcStats, pqCTStats)
385385
fmt.Printf("\n")
386-
fmt.Printf("new + PQ would be the same as new.\n")
386+
fmt.Printf("(PQ MTC and MTC tiles have the same size.)\n")
387387
return nil
388388
}
389389

0 commit comments

Comments
 (0)