|
1 | 1 | { |
2 | 2 | "magic": "E!vIA5L86J2I", |
3 | | - "timestamp": "2025-10-12T02:02:46.519827+00:00", |
| 3 | + "timestamp": "2025-10-14T01:56:19.944525+00:00", |
4 | 4 | "repo": "davidben/merkle-tree-certs", |
5 | 5 | "labels": [ |
6 | 6 | { |
|
8869 | 8869 | "labels": [], |
8870 | 8870 | "body": "CC @nharper\r\n \r\nCloses #147", |
8871 | 8871 | "createdAt": "2025-10-06T16:34:12Z", |
8872 | | - "updatedAt": "2025-10-10T23:24:11Z", |
| 8872 | + "updatedAt": "2025-10-12T17:48:36Z", |
8873 | 8873 | "baseRepository": "davidben/merkle-tree-certs", |
8874 | 8874 | "baseRefName": "main", |
8875 | | - "baseRefOid": "ddafe7889a99a477a99e2eb0a9da1fe555b58a27", |
| 8875 | + "baseRefOid": "8fd36010dd8e613b3f566be965c6872a89b85475", |
8876 | 8876 | "headRepository": "davidben/merkle-tree-certs", |
8877 | 8877 | "headRefName": "proof-explain", |
8878 | | - "headRefOid": "3ffb3a1b3831acdf673e818d3cfee8f18584046c", |
| 8878 | + "headRefOid": "f7da5bc66b0ecc7df586e5e90c8d4d01073816c9", |
8879 | 8879 | "closedAt": null, |
8880 | 8880 | "mergedAt": null, |
8881 | 8881 | "mergedBy": null, |
|
8963 | 8963 | "updatedAt": "2025-10-10T23:24:11Z" |
8964 | 8964 | } |
8965 | 8965 | ] |
| 8966 | + }, |
| 8967 | + { |
| 8968 | + "id": "PRR_kwDOJIBkVc7GRwtG", |
| 8969 | + "commit": { |
| 8970 | + "abbreviatedOid": "3ffb3a1" |
| 8971 | + }, |
| 8972 | + "author": "davidben", |
| 8973 | + "authorAssociation": "OWNER", |
| 8974 | + "state": "COMMENTED", |
| 8975 | + "body": "Made a bunch of changes, including to supporting text.", |
| 8976 | + "createdAt": "2025-10-11T03:11:56Z", |
| 8977 | + "updatedAt": "2025-10-12T17:45:46Z", |
| 8978 | + "comments": [ |
| 8979 | + { |
| 8980 | + "originalPosition": 128, |
| 8981 | + "body": "Whoops, yes. Fixed.", |
| 8982 | + "createdAt": "2025-10-11T03:11:56Z", |
| 8983 | + "updatedAt": "2025-10-12T17:45:46Z" |
| 8984 | + }, |
| 8985 | + { |
| 8986 | + "originalPosition": 62, |
| 8987 | + "body": "I'm not sure what the convention is. At one point I gave everything names, but that got tedious. Other docs I've not seen bother. For this I mostly didn't bother and just did it for these two subsections because they'd otherwise risk colliding with the actual one. \ud83e\udd37 ", |
| 8988 | + "createdAt": "2025-10-11T03:13:00Z", |
| 8989 | + "updatedAt": "2025-10-12T17:45:46Z" |
| 8990 | + }, |
| 8991 | + { |
| 8992 | + "originalPosition": 148, |
| 8993 | + "body": "Ah yeah, things got jumbled when the steps were renumbered in another PR. Fixed.", |
| 8994 | + "createdAt": "2025-10-11T03:24:04Z", |
| 8995 | + "updatedAt": "2025-10-12T17:45:46Z" |
| 8996 | + }, |
| 8997 | + { |
| 8998 | + "originalPosition": 122, |
| 8999 | + "body": "Think that fit slightly better in the next paragraph, but added something to this effect. I added some text in the previous section to make it clear that the right edge and the path to the last element are the same. (It seems to work better to talk about paths.)", |
| 9000 | + "createdAt": "2025-10-12T16:50:14Z", |
| 9001 | + "updatedAt": "2025-10-12T17:45:46Z" |
| 9002 | + }, |
| 9003 | + { |
| 9004 | + "originalPosition": 124, |
| 9005 | + "body": "Hmm. I tend to think of every tree as having infinite levels. If zeros on the right edge mean \"skip\", that just means there are infinitely many \"skip\" directives at the front of every path. (Subtrees also potentially have infinite levels, but past some point, zeros and ones both mean \"skip\". Or you subtract `start` and that removes the ones.) But I think this is probably what equivalent interpretation makes most sense to you.\r\n\r\nI added \"When `sn` is zero, the procedure has reached the top of the tree.\" I think there's lots of ways to see why (including \"In this numbering, a node's level can be determined as follows: if the node is a root of subtree `[start, end)`, the node's level is `BIT_WIDTH(end - start - 1)`\") that we can probably just assert that and let the reader justify it to themselves in whatever way makes most sense. This doesn't need to be a rigorous proof, just enough to get the intuition across.", |
| 9006 | + "createdAt": "2025-10-12T16:57:40Z", |
| 9007 | + "updatedAt": "2025-10-12T17:45:46Z" |
| 9008 | + }, |
| 9009 | + { |
| 9010 | + "originalPosition": 136, |
| 9011 | + "body": "I think in part because it's wrong. :-) (It's not the right edge of the tree) I've rephrased it and elaborated.", |
| 9012 | + "createdAt": "2025-10-12T17:26:52Z", |
| 9013 | + "updatedAt": "2025-10-12T17:45:46Z" |
| 9014 | + }, |
| 9015 | + { |
| 9016 | + "originalPosition": 132, |
| 9017 | + "body": "Added some notes about first, second, and third number. Agreed the variable names are horrid. I'm on board with changing them. Maybe we can do better than first/second/third in the first place, I dunno.", |
| 9018 | + "createdAt": "2025-10-12T17:36:59Z", |
| 9019 | + "updatedAt": "2025-10-12T17:45:46Z" |
| 9020 | + }, |
| 9021 | + { |
| 9022 | + "originalPosition": 151, |
| 9023 | + "body": "Mostly it's assumed you already read the inclusion proof one. It's really the same function, we're just doing more work along the side. Expanded on it a bit.", |
| 9024 | + "createdAt": "2025-10-12T17:40:30Z", |
| 9025 | + "updatedAt": "2025-10-12T17:45:46Z" |
| 9026 | + } |
| 9027 | + ] |
8966 | 9028 | } |
8967 | 9029 | ] |
8968 | 9030 | }, |
|
0 commit comments