[Feature Request]: Suggestions for git subcommands

[RafaelKr]

What do you want us to work on?

I just got No suggestion found for command: git stash poop.

The original error output was fatal: subcommand wasn't specified; 'push' can't be assumed due to unexpected token 'poop'.

Is there a syntax to handle suggestions in the scope of the subcommand? So for git stash it should be aware of the subcommands available: https://git-scm.com/docs/git-stash

[RafaelKr]

I found this helpful Stack Overflow entry https://stackoverflow.com/a/79209306/4303873 which mentions --git-completion-helper.

If you type git stash --git-completion-helper inside a directory where a git repository is initialized, it will output: apply clear drop pop branch list show store create push.

There is also --git-completion-helper-all, although I couldn't figure out the difference: https://github.com/git/git/blob/1a8a4971cc6c179c4dd711f4a7f5d7178f4b3ab7/contrib/completion/git-completion.bash#L480-L520

FWIW: In that SO entry they also talk about git --list-cmds=.... In git-completion.bash I linked in the paragraph above they use git --list-cmds=main,others,alias,nohelpers inside a __git_compute_all_commands function.

[iffse]

Something like

[[match_err]]
pattern = [
	"subcommand wasn't specified"
]
suggest = [
'''
#[err_contains(can't be assumed due to unexpected token)]
{{command[0:1]}} {{typo[2]({{shell({{command[0:1]}} --git-completion-helper)}})}} {{command[3:]}}''',
]

Should do the trick. Note that the rule above does not work currently, as the shell placeholder does not support this syntax yet.

Can be hardcoded though:

[[match_err]]
pattern = [
	"subcommand wasn't specified"
]
suggest = [
'''
#[
err_contains(can't be assumed due to unexpected token),
cmd_contains(git stash)
]
{{command[0:1]}} {{typo[2]({{shell(git stash --git-completion-helper)}})}} {{command[3:]}}''',
]

[iffse]

Will be implemented. If it's urgent, you can always just use a shell script as a module instead of TOML rules.

[RafaelKr]

Awesome, thanks! And no, it's not urgent, at least I don't plan to do a lot of typos 😆