Different sources for light/dark mode

[crepererum]

(Maybe that's already possible and I just missed it)

It nice to have different sources for light and dark mode, so that the color of the wallpaper kinda matches the mode/theme.

[Lucki]

Do you have examples for dark/light-only sources?

[crepererum]

I thought about using keywords, e.g.

• dark: https://unsplash.com/s/photos/forest-night
• light: https://unsplash.com/s/photos/beach

Now of course this isn't perfect. You can see some pictures in "night" example being rather bright, but I think it's good enough. Another option would be to use category-based search terms, e.g.:

• dark: https://unsplash.com/s/photos/dark-mode-wallpaper
• dark: https://unsplash.com/s/photos/black-background
• light: https://unsplash.com/s/photos/white-background

[Lucki]

This would need the following changes:

• adding a setting to the general schema list:
  

  RandomWallpaperGnome3/src/schemas/org.gnome.shell.extensions.space.iflow.randomwallpaper.gschema.xml

  Lines 149 to 175 in 116b43c

  	<schema id='org.gnome.shell.extensions.space.iflow.randomwallpaper.sources.general'>
  	<key type='as' name='blocked-images'>
  	<default>[]</default>
  	<summary>Blocked Images</summary>
  	<description>An array of strings containing the filenames of blocked images.</description>
  	</key>
  	<key type='b' name='enabled'>
  	<default>true</default>
  	<summary>Enabled</summary>
  	<description>Whether this source is enabled.</description>
  	</key>
  	<key type='s' name='name'>
  	<default>"MySource"</default>
  	<summary>Name</summary>
  	<description>Name for this source.</description>
  	</key>
  	<key type='i' name='type'>
  	<default>-1</default>
  	<summary>Type</summary>
  	<description>The type of this source.</description>
  	</key>
  	</schema>

• adding a general UI option for considering this source in dark, light or both:
  https://github.com/ifl0w/RandomWallpaperGnome3/blob/develop/src/ui/sourceRow.blp
• connecting the UI to the underlying settings schema:
  https://github.com/ifl0w/RandomWallpaperGnome3/blob/develop/src/ui/sourceRow.ts
• reading /org/gnome/desktop/interface/color-scheme as well as the own newly added setting and filtering the sources accordingly:
  

  RandomWallpaperGnome3/src/wallpaperController.ts

  Lines 359 to 389 in 116b43c

  	/**
  	* Gets randomly $count amount of enabled sources.
  	*
  	* The same source can appear multiple times in the resulting array.
  	*
  	* @param {number} count Amount of requested source IDs
  	* @returns {string[]} Array of source IDs or ['-1'] in case of failure
  	*/
  	private _getRandomSource(count: number): string[] {
  	const sourceResult: string[] = [];
  	const sources: string[] = this._settings.getStrv('sources');
  	if (sources === null || sources.length < 1)
  	return ['-1'];
  	const enabledSources = sources.filter(element => {
  	const path = `${SettingsModule.RWG_SETTINGS_SCHEMA_PATH}/sources/general/${element}/`;
  	const settingsGeneral = new SettingsModule.Settings(SettingsModule.RWG_SETTINGS_SCHEMA_SOURCES_GENERAL, path);
  	return settingsGeneral.getBoolean('enabled');
  	});
  	if (enabledSources === null || enabledSources.length < 1)
  	return ['-1'];
  	for (let index = 0; index < count; index++) {
  	const chosenSource = enabledSources[Utils.getRandomNumber(enabledSources.length)];
  	sourceResult.push(chosenSource);
  	}
  	return sourceResult;
  	}

• This would already give that functionality.
  But to be super correct, the various managers would also need adjustments to only set the wallpaper of the current mode.
  Currently, all manager always set the wallpapers for both modes.
  https://github.com/ifl0w/RandomWallpaperGnome3/tree/develop/src/manager
• Edit: The history handling probably also needs some handling.