Alternate names and faster bulk loading#33
Open
brunobg wants to merge 18 commits into
Open
Conversation
Author
|
Actually, there are some endpoints not working with alternatenames. I'll post the fixes soon. |
Author
|
Ok, this fixes the issues I had before and a bunch of extra bugs:
All routes listed in README were properly tested. There's bug #32 still open on Sorry this PR grew so big. My initial idea was just to add alternate names but I kept finding issues and did not fork for each one. |
Open
|
Look like package is abandoned, thx for your work. I use your fork instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR that does two things:
Sorry they were mixed, I was not planning to do the bulk insert but it was just impossible to develop and to load the alternate names without it, so it all got mixed in the end.
The alternate names db is optional and loaded by a separate artisan command. It's completely backwards compatible with previous installations.
I added a few extra query options to the API to select specific languages, which hopefully solves the i18n problem.
I tried to add automatic tests, but I couldn't figure out how you run the test setup. I suggest you document this somewhere. So I only tested the endpoints manually, but covered (hopefully) all cases.