Skip to content

Commit 21e13b6

Browse files
committed
chore(core,clippy): remove redundant .clone() in rollout items
Replace unnecessary .clone() calls when pushing ResponseItem instances in sample_rollout test. Moves user and assistant values into RolloutItem::ResponseItem (user1, assistant1, user2, assistant2) instead of cloning them, eliminating needless clones
1 parent 460ef45 commit 21e13b6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

codex-rs/core/src/codex_tests.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3916,7 +3916,7 @@ async fn sample_rollout(
39163916
std::iter::once(&user1),
39173917
reconstruction_turn.truncation_policy,
39183918
);
3919-
rollout_items.push(RolloutItem::ResponseItem(user1.clone()));
3919+
rollout_items.push(RolloutItem::ResponseItem(user1));
39203920

39213921
let assistant1 = ResponseItem::Message {
39223922
id: None,
@@ -3931,7 +3931,7 @@ async fn sample_rollout(
39313931
std::iter::once(&assistant1),
39323932
reconstruction_turn.truncation_policy,
39333933
);
3934-
rollout_items.push(RolloutItem::ResponseItem(assistant1.clone()));
3934+
rollout_items.push(RolloutItem::ResponseItem(assistant1));
39353935

39363936
let summary1 = "summary one";
39373937
let snapshot1 = live_history
@@ -3958,7 +3958,7 @@ async fn sample_rollout(
39583958
std::iter::once(&user2),
39593959
reconstruction_turn.truncation_policy,
39603960
);
3961-
rollout_items.push(RolloutItem::ResponseItem(user2.clone()));
3961+
rollout_items.push(RolloutItem::ResponseItem(user2));
39623962

39633963
let assistant2 = ResponseItem::Message {
39643964
id: None,
@@ -3973,7 +3973,7 @@ async fn sample_rollout(
39733973
std::iter::once(&assistant2),
39743974
reconstruction_turn.truncation_policy,
39753975
);
3976-
rollout_items.push(RolloutItem::ResponseItem(assistant2.clone()));
3976+
rollout_items.push(RolloutItem::ResponseItem(assistant2));
39773977

39783978
let summary2 = "summary two";
39793979
let snapshot2 = live_history

0 commit comments

Comments
 (0)