Skip to content

Commit 2f4e30f

Browse files
committed
chore(core,clippy): remove redundant .clone() in rollout items
Replace unnecessary .clone() calls when pushing ResponseItem instances in sample_rollout test. Moves user and assistant values into RolloutItem::ResponseItem (user1, assistant1, user2, assistant2) instead of cloning them, eliminating needless clones
1 parent 9706e79 commit 2f4e30f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

codex-rs/core/src/codex_tests.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4048,7 +4048,7 @@ async fn sample_rollout(
40484048
std::iter::once(&user1),
40494049
reconstruction_turn.truncation_policy,
40504050
);
4051-
rollout_items.push(RolloutItem::ResponseItem(user1.clone()));
4051+
rollout_items.push(RolloutItem::ResponseItem(user1));
40524052

40534053
let assistant1 = ResponseItem::Message {
40544054
id: None,
@@ -4063,7 +4063,7 @@ async fn sample_rollout(
40634063
std::iter::once(&assistant1),
40644064
reconstruction_turn.truncation_policy,
40654065
);
4066-
rollout_items.push(RolloutItem::ResponseItem(assistant1.clone()));
4066+
rollout_items.push(RolloutItem::ResponseItem(assistant1));
40674067

40684068
let summary1 = "summary one";
40694069
let snapshot1 = live_history
@@ -4090,7 +4090,7 @@ async fn sample_rollout(
40904090
std::iter::once(&user2),
40914091
reconstruction_turn.truncation_policy,
40924092
);
4093-
rollout_items.push(RolloutItem::ResponseItem(user2.clone()));
4093+
rollout_items.push(RolloutItem::ResponseItem(user2));
40944094

40954095
let assistant2 = ResponseItem::Message {
40964096
id: None,
@@ -4105,7 +4105,7 @@ async fn sample_rollout(
41054105
std::iter::once(&assistant2),
41064106
reconstruction_turn.truncation_policy,
41074107
);
4108-
rollout_items.push(RolloutItem::ResponseItem(assistant2.clone()));
4108+
rollout_items.push(RolloutItem::ResponseItem(assistant2));
41094109

41104110
let summary2 = "summary two";
41114111
let snapshot2 = live_history

0 commit comments

Comments
 (0)