Skip to content

Commit 648cdee

Browse files
committed
chore(core,clippy): remove redundant .clone() in rollout items
Replace unnecessary .clone() calls when pushing ResponseItem instances in sample_rollout test. Moves user and assistant values into RolloutItem::ResponseItem (user1, assistant1, user2, assistant2) instead of cloning them, eliminating needless clones
1 parent cf90f92 commit 648cdee

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

codex-rs/core/src/codex_tests.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4465,7 +4465,7 @@ async fn sample_rollout(
44654465
std::iter::once(&user1),
44664466
reconstruction_turn.truncation_policy,
44674467
);
4468-
rollout_items.push(RolloutItem::ResponseItem(user1.clone()));
4468+
rollout_items.push(RolloutItem::ResponseItem(user1));
44694469

44704470
let assistant1 = ResponseItem::Message {
44714471
id: None,
@@ -4480,7 +4480,7 @@ async fn sample_rollout(
44804480
std::iter::once(&assistant1),
44814481
reconstruction_turn.truncation_policy,
44824482
);
4483-
rollout_items.push(RolloutItem::ResponseItem(assistant1.clone()));
4483+
rollout_items.push(RolloutItem::ResponseItem(assistant1));
44844484

44854485
let summary1 = "summary one";
44864486
let snapshot1 = live_history
@@ -4507,7 +4507,7 @@ async fn sample_rollout(
45074507
std::iter::once(&user2),
45084508
reconstruction_turn.truncation_policy,
45094509
);
4510-
rollout_items.push(RolloutItem::ResponseItem(user2.clone()));
4510+
rollout_items.push(RolloutItem::ResponseItem(user2));
45114511

45124512
let assistant2 = ResponseItem::Message {
45134513
id: None,
@@ -4522,7 +4522,7 @@ async fn sample_rollout(
45224522
std::iter::once(&assistant2),
45234523
reconstruction_turn.truncation_policy,
45244524
);
4525-
rollout_items.push(RolloutItem::ResponseItem(assistant2.clone()));
4525+
rollout_items.push(RolloutItem::ResponseItem(assistant2));
45264526

45274527
let summary2 = "summary two";
45284528
let snapshot2 = live_history

0 commit comments

Comments
 (0)