Update to SpotBugs 6.2.4

Author: GregDThomas

build.gradle

@@ -7,7 +7,7 @@ plugins {
     id 'java-library'
     id 'maven-publish'
     id 'checkstyle'
-    id 'com.github.spotbugs' version '6.2.3'
+    id 'com.github.spotbugs' version '6.2.4'
     id 'com.github.ben-manes.versions' version '0.52.0'
 }
 
@@ -97,7 +97,7 @@ dependencies {
 
     testImplementation platform('org.junit:junit-bom:5.13.4')
     testImplementation 'org.junit.jupiter:junit-jupiter-api'
-    testImplementation 'org.mockito:mockito-junit-jupiter:5.18.0'
+    testImplementation 'org.mockito:mockito-junit-jupiter:5.19.0'
     testImplementation 'org.assertj:assertj-core:3.27.4'
 
     testRuntimeOnly 'org.junit.platform:junit-platform-launcher'

src/test/java/org/jivesoftware/openfire/plugin/passwordreset/Fixtures.java

@@ -6,7 +6,6 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.withSettings;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.File;
 import java.net.URL;
 import lombok.SneakyThrows;
@@ -72,9 +71,6 @@ public static void clearExistingProperties() {
      *
      * @return a mock XMPPServer
      */
-    @SuppressFBWarnings(
-        value = "RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT",
-        justification = "False positive")
     public static XMPPServer mockXmppServer() {
         final XMPPServer xmppServer = mock(
             XMPPServer.class,

src/test/java/org/jivesoftware/openfire/plugin/passwordreset/servlet/client/PasswordResetChangePasswordServletTest.java

@@ -10,7 +10,6 @@
 import static org.mockito.Mockito.never;
 import static org.mockito.Mockito.verify;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.sql.SQLException;
 import java.util.Optional;
 import javax.servlet.RequestDispatcher;
@@ -162,9 +161,6 @@ void postWithNothingWillRedirect() {
 
     @SneakyThrows
     @Test
-    @SuppressFBWarnings(
-        value = "RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT",
-        justification = "False positive")
     void validFormWillUpdatePasswordAndRedirect() {
 
         givenValidFormSubmission();
@@ -298,9 +294,6 @@ void badTokenWillRedirectToBadTokenPage() {
 
     @SneakyThrows
     @Test
-    @SuppressFBWarnings(
-        value = "RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT",
-        justification = "False positive")
     void differentUserIdWillRedirectToBadTokenPage() {
 
         givenValidFormSubmission();