Fix a few remember bugs

Author: ihateblueb

CHANGELOG.md

@@ -1,5 +1,4 @@
 # Snowdrop Changelog
-Hello :3 :3 :3
 
 ## [Unreleased]
 

shared/src/commonMain/kotlin/site/remlit/snowdrop/component/EmojiPicker.kt

@@ -19,6 +19,7 @@ import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateMapOf
+import androidx.compose.runtime.remember
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.text.font.FontWeight
@@ -50,7 +51,7 @@ fun EmojiPicker(
 		enter = bottomNavEnterAnimation,
 		exit = bottomNavExitAnimation
 	) {
-		val emojis by fetchEmojis().collectAsStateWithLifecycle(emptyList())
+		val emojis by remember { fetchEmojis() }.collectAsStateWithLifecycle(emptyList())
 
 		val categorized = mutableMapOf<String, List<Emoji>>()
 

shared/src/commonMain/kotlin/site/remlit/snowdrop/component/Status.kt

@@ -158,7 +158,7 @@ fun Status(status: Status) {
 		.collectAsStateWithLifecycle(false)
 
 	/* View variables */
-	val currentAccount by getCurrentAccountObjectFlow().collectAsStateWithLifecycle(null)
+	val currentAccount by remember { getCurrentAccountObjectFlow() }.collectAsStateWithLifecycle(null)
 	var showEmojiPicker by remember { mutableStateOf(false) }
 
 	var realStatus by remember { mutableStateOf(status) }

shared/src/commonMain/kotlin/site/remlit/snowdrop/view/ComposeView.kt

@@ -44,6 +44,7 @@ import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import com.russhwolf.settings.ExperimentalSettingsApi
+import kotlinx.coroutines.flow.distinctUntilChanged
 import org.jetbrains.compose.resources.painterResource
 import org.jetbrains.compose.resources.stringResource
 import site.remlit.snowdrop.api.statuses.createStatus
@@ -62,6 +63,7 @@ import site.remlit.snowdrop.util.bgIO
 import site.remlit.snowdrop.util.blockingSettings
 import site.remlit.snowdrop.util.cache.fetchInstance
 import site.remlit.snowdrop.util.cache.fetchStatus
+import site.remlit.snowdrop.util.cache.fetchStatusOrNull
 import site.remlit.snowdrop.util.getCurrentAccountObjectFlow
 import snowdrop.shared.generated.resources.Res
 import snowdrop.shared.generated.resources.compose
@@ -115,19 +117,11 @@ fun ComposeView(
 			?: blockingSettings.getString("default_visibility", "public"))
 	}
 
-	var replyTarget by remember { mutableStateOf<Status?>(null) }
-	LaunchedEffect(inReplyToId) {
-		if (inReplyToId != null) fetchStatus(inReplyToId, snackbarHandler).collect {
-			replyTarget = it
-		}
-	}
+	val replyTarget by remember { fetchStatusOrNull(inReplyToId, snackbarHandler) }
+		.collectAsStateWithLifecycle(null)
 
-	var instance by remember { mutableStateOf<InstanceV1?>(null) }
-	LaunchedEffect(instance) {
-		if (instance != null) fetchInstance(snackbarHandler).collect {
-			instance = it
-		}
-	}
+	val instance by remember { fetchInstance(snackbarHandler) }
+		.collectAsStateWithLifecycle(null)
 	val maxChars = (instance?.maxTootChars ?: 500)
 	val remainingChars = maxChars - (content.length + cw.length)
 

shared/src/commonMain/kotlin/site/remlit/snowdrop/view/ThreadView.kt

@@ -45,10 +45,10 @@ fun ThreadView(id: String) = ViewSurface {
 	val navHandler = LocalNavController.current
 	val snackbarHandler = SnackbarController.current
 
-	val currentAccount by getCurrentAccountObjectFlow()
+	val currentAccount by remember { getCurrentAccountObjectFlow() }
 		.collectAsStateWithLifecycle(null)
 
-	val status by fetchStatus(id, snackbarHandler)
+	val status by remember { fetchStatus(id, snackbarHandler) }
 		.collectAsStateWithLifecycle(null)
 
 	val ancestors = remember { mutableStateListOf<Status>() }

shared/src/commonMain/kotlin/site/remlit/snowdrop/view/settings/AboutInstanceView.kt

@@ -18,6 +18,7 @@ import androidx.compose.material3.TopAppBar
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.getValue
+import androidx.compose.runtime.remember
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clip
@@ -42,7 +43,7 @@ import snowdrop.shared.generated.resources.icon_arrow_back_24
 fun AboutInstanceView() = ViewSurface {
 	val navHandler = LocalNavController.current
 
-	val instance by fetchInstance().collectAsStateWithLifecycle(null)
+	val instance by remember { fetchInstance() }.collectAsStateWithLifecycle(null)
 
 	TopAppBar(
 		navigationIcon = {