Loads of RndMat fixes; add caveat to HTML report

ihatecompvir · ihatecompvir · commit 3ebffb1c4391 · 2026-02-07T20:23:01.000-08:00
diff --git a/MiloLib.Tests/AssetIOTests.cs b/MiloLib.Tests/AssetIOTests.cs
@@ -57,13 +57,13 @@ public void RoundTrip_VerifyByteEquality(Type assetType)
         if (writeMethod == null || readMethod == null)
         {
             var msg = writeMethod == null ? "No Write method found" : "No Read method found";
-            for (ushort r = 0; r <= 50; r++)
+            for (ushort r = 0; r <= 100; r++)
                 TestResultCollector.RecordResult(assetType.Name, r, TestResultCollector.TestStatus.Failed, msg);
             return;
         }
 
         // sweet sweet parallelism
-        Parallel.For(0, 51, revision =>
+        Parallel.For(0, 101, revision =>
         {
             ushort rev = (ushort)revision;
             string? errorMessage = null;
diff --git a/MiloLib.Tests/HtmlReportGenerator.cs b/MiloLib.Tests/HtmlReportGenerator.cs
@@ -140,13 +140,19 @@ public static string GenerateReport(string outputPath)
 .count-badge{{font-size:11px;padding:1px 6px;border-radius:10px;font-weight:600}}
 .count-badge.p-badge{{background:#1b3a1b;color:#4caf50}}.count-badge.f-badge{{background:#3a1b1b;color:#ef5350}}.count-badge.s-badge{{background:#3a2a0f;color:#ffa726}}
 #no-match{{display:none;text-align:center;padding:40px;color:#555;font-size:14px}}
+.caveat{{background:#1e3a2a;border-left:4px solid #4caf50;border-radius:4px;padding:12px 16px;margin-bottom:16px;font-size:13px;color:#b0bec5;line-height:1.5}}
+.caveat strong{{color:#e0e0e0}}
 </style>
 </head>
 <body>
 
 <h1>MiloLib Round-Trip Serialization Test Report</h1>
 <p class=""subtitle"">Generated {DateTime.Now:yyyy-MM-dd HH:mm:ss} &mdash; {allResults.Count} asset types, revisions 0&ndash;{(allRevisions.Count > 0 ? allRevisions.Max : 0)}</p>
 
+<div class=""caveat"">
+  <strong>⚠ Caveat:</strong> This test only verifies that each asset's <code>Read()</code> and <code>Write()</code> functions are symmetric (i.e., write-read produces identical bytes). It does <strong>not</strong> validate that the implementation is correct. Missing or incorrect revision checks, invalid data, or other bugs will still pass if both Read and Write apply the same logic. Additionally, support for assets introduced after Rock Band 3 is limited.
+</div>
+
 <div class=""stats"">
   <div class=""stat""><div class=""label"">Total Tests</div><div class=""val blue"">{totalTests}</div></div>
   <div class=""stat""><div class=""label"">Passed</div><div class=""val green"">{passedTests}</div></div>
diff --git a/MiloLib/Assets/Rnd/RndMat.cs b/MiloLib/Assets/Rnd/RndMat.cs

Original file line number	Diff line number	Diff line change
`@@ -57,13 +57,13 @@ public void RoundTrip_VerifyByteEquality(Type assetType)`
`57`	`57`	`if (writeMethod == null \|\| readMethod == null)`
`58`	`58`	`{`
`59`	`59`	`var msg = writeMethod == null ? "No Write method found" : "No Read method found";`
`60`		`- for (ushort r = 0; r <= 50; r++)`
	`60`	`+ for (ushort r = 0; r <= 100; r++)`
`61`	`61`	`TestResultCollector.RecordResult(assetType.Name, r, TestResultCollector.TestStatus.Failed, msg);`
`62`	`62`	`return;`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`// sweet sweet parallelism`
`66`		`- Parallel.For(0, 51, revision =>`
	`66`	`+ Parallel.For(0, 101, revision =>`
`67`	`67`	`{`
`68`	`68`	`ushort rev = (ushort)revision;`
`69`	`69`	`string? errorMessage = null;`