Adventure map, Sign and Bottle without text should randomly display predefined texts

[LeHerosInconnu]

Preliminary checks

• I've checked that there aren't other open issues on the same topic.
• I've checked that this issue is reproducible on the latest snapshot build.

Platform

Windows

Describe the bug

In fheroes2, the Sign and Bottle without text should randomly display predefined texts. [Done]
In original game, these texts are displayed when it is the case:

"Next sign 50 miles"
"Burma shave"
"See Rock City"
"This space for rent"

Edit.

Random texts should be assigned at the beginning of the scenario so that when a player visits the same sign several times, the same text is displayed.
The same goes for bottles, if a player visits a bottle, and loads a previous save, the same text should be displayed.

Note: the yellow titles "Sign" and "Bottle" must be kept in fheroes2.

Suggestions.

Question: should we put a dot "." at the end of these texts (to remain consistent with the texts of the other game windows)?
I am in favor of this.

Also, the text "This space for rent" is not really fitting for the Bottle because the Bottle disappears after being visited.
What do you think about this to replace it:
(From the original "Mission: Impossible" TV series.)

"This message will self-destruct in five seconds. Good luck Jim."

Or just:
(If you think it would be necessary in order to eventually avoid copyrights.)

"This message will self-destruct in five seconds."

I also suggest, for the Bottle, to remplace the text by:

"Next bottle 50 miles"

Instead of:

"Next sign 50 miles"

In original game:

In fheroes2:

Save file

Here are the save files:
Before signs and bottles 01.zip

Additional info

No response

[pflugs30]

I continue to be amazed at how thorough you are in your testing. 😀 Good find!

[ihhub]

Haha, burma shave...

[pflugs30]

@zenseii more translations coming... 😉

[LeHerosInconnu]

Hello @pflugs30,

I continue to be amazed at how thorough you are in your testing. 😀 Good find!

Ah, that's also why there are still over 400 issues. 🤣

[ihhub]

Hello @pflugs30,

I continue to be amazed at how thorough you are in your testing. 😀 Good find!

Ah, that's also why there are still over 400 issues. 🤣

and this disturbs me all the time...

[LeHerosInconnu]

Hello @ihhub,

Hello @pflugs30,

I continue to be amazed at how thorough you are in your testing. grinning Good find!

Ah, that's also why there are still over 400 issues. 🤣

and this disturbs me all the time...

"I don't understand.
The more issues I correct, the more there are." 🤣

[zenseii]

Should these be considered the same issue as these missing strings for when you pick up an artifact?

In the map editor this telescope is a random artifact. If I load and return to this spot I will always get this message.

[LeHerosInconnu]

Hello @zenseii,

Should these be considered the same issue as these missing strings for when you pick up an artifact?

In the map editor this telescope is a random artifact. If I load and return to this spot I will always get this message.

When artifacts are set to random in the scenario editor, this means that at the beginning of the scenario all these artifacts are set.
After that, if a player loads a save game that he made as soon as he got the hand (or any time later in the game), all these random artifacts will always be the same.

Now, if a player restarts a scenario completely (new game), the random artifacts are set at the beginning of the scenario and are different from another game of the same scenario.

[ihhub]

Hi @LeHerosInconnu , I've added the original behavior of signs and bottles. Could you please update your first post to indicate the suggestions over the original game?

[LeHerosInconnu]

Hello @ihhub,

Hi @LeHerosInconnu , I've added the original behavior of signs and bottles. Could you please update your first post to indicate the suggestions over the original game?

Done.

[ihhub]

The original issue had been fixed. We need to agree on new changes for texts.