Combat, functioning of genie ability and damage display #8409
Description
Preliminary checks
- I've checked that there aren't other open issues on the same topic.
- I've checked that this issue is reproducible on the latest snapshot build.
Platform
Windows
Describe the bug
In the original game, when the genie's ability comes into play, half the number of creatures, rounded up, are removed from the initial group, while the "first" creature's hit points are retained.
In the example, the troop of 13 giants is reduced to 6 giants (13 / 2 = 6,5 rounded up to 7, 13 - 7 = 6), and the 72 hit points of the first creature are retained.
In fheroes2, this is not the case.
The troop of 13 giants is reduced to 7 giants, and the 133 hit points of the first creature are reduced to 67 hit points.
Moreover, as the ability reduces the number of creatures, it is not necessary to display the damage supposedly suffered in the combat logs.
Only the number of creatures eliminated should be displayed, in the example with the correction applied:
"Genie destroys half the enemy troop!
7 giants perishs."
Eventually on the same line:
"Genie destroys half the enemy troop, 7 giants perish!"
In Heroes 2:
2024-02-15.12-12-17.mp4
In fheroes2:
2024-02-15.12-29-30.mp4
Save file
Here are the save file and the test scenario file:
Genie ability bug 01.zip
Additional info
Related closed issue: #3609.