Fix infinite recursion (#122)

* don't do the parent dict

* Update CHANGELOG.rst

* use name or repr for parent

Author: patricktnast

CHANGELOG.rst

@@ -1,3 +1,7 @@
+**4.1.2 - 12/3/24**
+
+ - Fix infinite recursion bug
+
 **4.1.1 - 12/2/24**
 
  - Properly clean up Jenkins workspaces

src/gbd_mapping/base_template.py

@@ -10,12 +10,14 @@
 class GbdRecord:
     """Base class for entities modeled in the GBD."""
     __slots__ = ()
-    
+
     def to_dict(self):
         out = {}
         for item in self.__slots__:
             attr = getattr(self, item)
-            if isinstance(attr, GbdRecord):
+            if item == "parent":
+                out[item] = attr.name if hasattr(attr, "name") else attr.__repr__()
+            elif isinstance(attr, GbdRecord):
                 out[item] = attr.to_dict()
             elif isinstance(attr, tuple) and attr:
                 if isinstance(attr[0], GbdRecord):
@@ -38,7 +40,7 @@ def __getitem__(self, item):
     def __iter__(self):
         for item in self.__slots__:
             yield getattr(self, item)
-            
+
     def __eq__(self, other):
         return all([getattr(self, item) == getattr(other, item) for item in self.__slots__
                     if not isinstance(getattr(self, item), GbdRecord)])

tests/test_base_template.py

@@ -0,0 +1,17 @@
+from gbd_mapping.base_template import GbdRecord
+
+
+class TestGbdRecord(GbdRecord):
+    __slots__ = ("name", "parent")
+
+    def __init__(self, name, parent=None):
+        super().__init__()
+        self.name = name
+        self.parent = parent
+
+
+def test_to_dict():
+    record = TestGbdRecord(name="record1")
+    record2 = TestGbdRecord(name="record2", parent=record)
+    record.parent = record2
+    record.to_dict()