Skip to content

Commit 2866542

Browse files
pr review updates
1 parent f97a25a commit 2866542

File tree

3 files changed

+18
-9
lines changed

3 files changed

+18
-9
lines changed

CHANGELOG.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
**2.1.5 - TBD**
1+
**2.1.5 - 07/25/25**
22

33
- Feature: Support new environment creation via 'make build-env'
44

Makefile

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,30 @@
11
# Check if we're running in Jenkins
22
ifdef JENKINS_URL
3-
# Files are already in workspace from shared library
3+
# Files are already in workspace from shared library
44
MAKE_INCLUDES := .
55
else
6-
# For local dev, use the installed vivarium_build_utils package
7-
MAKE_INCLUDES := $(shell python -c "import vivarium_build_utils.resources" &>/dev/null && python -c "from vivarium_build_utils.resources import get_makefiles_path; print(get_makefiles_path())")
6+
# For local dev, use the installed vivarium_build_utils package if it exists
7+
# First, check if we can import vivarium_build_utils and assign 'yes' or 'no'.
8+
# We do this by importing the package in python and redirecting stderr to the null device.
9+
# If the import is successful (&&), it will print 'yes', otherwise (||) it will print 'no'.
10+
VIVARIUM_BUILD_UTILS_AVAILABLE := $(shell python -c "import vivarium_build_utils" 2>/dev/null && echo "yes" || echo "no")
11+
# If vivarium_build_utils is available, get the makefiles path or else set it to empty
12+
ifeq ($(VIVARIUM_BUILD_UTILS_AVAILABLE),yes)
13+
MAKE_INCLUDES := $(shell python -c "from vivarium_build_utils.resources import get_makefiles_path; print(get_makefiles_path())")
14+
else
15+
MAKE_INCLUDES :=
16+
endif
817
endif
918

19+
# Set the package name as the last part of this file's parent directory path
1020
PACKAGE_NAME = $(notdir $(CURDIR))
1121

22+
ifneq ($(MAKE_INCLUDES),) # not empty
1223
# Include makefiles from vivarium_build_utils
13-
ifneq ($(MAKE_INCLUDES),) # if not an empty string
1424
include $(MAKE_INCLUDES)/base.mk
1525
include $(MAKE_INCLUDES)/test.mk
16-
endif
17-
18-
ifeq ($(MAKE_INCLUDES),) # empty string
26+
else # empty
27+
# Use this help message (since the vivarium_build_utils version is not available)
1928
help:
2029
@echo
2130
@echo "For Make's standard help, run 'make --help'."

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
long_description = f.read()
4444

4545
install_requirements = [
46-
"vivarium_build_utils>=1.1.0,<2.0.0",
46+
"vivarium_build_utils>=2.0.1,<3.0.0",
4747
"numpy",
4848
"pandas",
4949
"scipy",

0 commit comments

Comments
 (0)