[Copilot] package names should use hyphens in deploy script

Author: rmudambi

.github/workflows/deploy.yml

@@ -12,7 +12,7 @@ on:
         type: choice
         options:
         - core
-        - public_health
+        - public-health
 
 jobs:
   deploy:
@@ -27,16 +27,17 @@ jobs:
             # Extract package name from tag by stripping version (core-v1.0.0 -> core, public-health-v1.0.0 -> public-health)
             TAG_NAME="${{ github.event.release.tag_name }}"
             # Remove -v* suffix to get package name, then convert hyphens to underscores for public_health
-            PACKAGE_RAW="${TAG_NAME%-v*}"
-            PACKAGE_NAME="${PACKAGE_RAW//-/_}"
+            PACKAGE_INPUT="${TAG_NAME%-v*}"
+            PACKAGE_NAME="${PACKAGE_INPUT//-/_}"
           else
             # Use input directly for workflow_dispatch
-            PACKAGE_NAME="${{ github.event.inputs.package }}"
+            PACKAGE_INPUT="${{ github.event.inputs.package }}"
+            PACKAGE_NAME="${PACKAGE_INPUT//-/_}"  # Convert hyphens to underscores for paths
           fi
           
           # Transform package name to path and tag pattern using string manipulation
           PACKAGE_PATH="libs/${PACKAGE_NAME}"
-          TAG_PATTERN="${PACKAGE_NAME//_/-}-v"  # public_health -> public-health-v, core -> core-v
+          TAG_PATTERN="${PACKAGE_INPUT}-v"  # public_health -> public-health-v, core -> core-v
           
           echo "PACKAGE_NAME=$PACKAGE_NAME" >> $GITHUB_ENV
           echo "PACKAGE_PATH=$PACKAGE_PATH" >> $GITHUB_ENV
@@ -54,24 +55,24 @@ jobs:
         run: |
           curl -LsSf https://astral.sh/uv/install.sh | sh
           echo "$HOME/.cargo/bin" >> $GITHUB_PATH
-      - name: Fetch git tags for ${PACKAGE_NAME}
+      - name: Fetch git tags for package
         run: |
           git fetch --depth=1 origin +refs/tags/*:refs/tags/*
-          echo "Available ${PACKAGE_NAME} tags:"
+          echo "Available ${PACKAGE_INPUT} tags:"
           git tag --list "${TAG_PATTERN}*" | head -10
-          echo "Current git describe for ${PACKAGE_NAME} tags:"
-          git describe --tags --match "${TAG_PATTERN}*" || echo "No ${PACKAGE_NAME} tags found"
+          echo "Current git describe for ${PACKAGE_INPUT} tags:"
+          git describe --tags --match "${TAG_PATTERN}*" || echo "No ${PACKAGE_INPUT} tags found"
           echo "Git log --oneline (last 5):"
           git log --oneline -5
       - name: Install dependencies
         run: |
           python --version
           uv pip install --system setuptools wheel build
-      - name: Build ${PACKAGE_NAME}
+      - name: Build package
         run: |
           cd ${PACKAGE_PATH}
           python -m build
-      - name: Publish ${PACKAGE_NAME} to PyPI
+      - name: Publish package to PyPI
         uses: pypa/gh-action-pypi-publish@release/v1
         with:
           packages-dir: ${{ env.PACKAGE_PATH }}/dist/