use a fixture instead

Author: patricktnast

tests/test_extraction.py

@@ -1,7 +1,5 @@
 """Unit tests for extraction utilities."""
 
-import tempfile
-from contextlib import contextmanager
 from pathlib import Path
 
 import pytest
@@ -16,17 +14,14 @@
 )
 
 
-@contextmanager
-def temp_yaml_file(yaml_content: str):
-    """Context manager for creating and cleaning up temporary YAML files."""
-    with tempfile.NamedTemporaryFile(mode="w", suffix=".yaml", delete=False) as f:
-        f.write(yaml_content)
-        yaml_path = Path(f.name)
-
-    try:
-        yield yaml_path
-    finally:
-        yaml_path.unlink()
+@pytest.fixture
+def temp_yaml_file(tmp_path):
+    """Fixture for creating temporary YAML files."""
+    def _create_yaml(yaml_content: str) -> Path:
+        yaml_path = tmp_path / "config.yaml"
+        yaml_path.write_text(yaml_content)
+        return yaml_path
+    return _create_yaml
 
 
 class TestCallPattern:
@@ -231,7 +226,7 @@ def test_extract_metrics_missing_patterns(self, sample_stats_file):
 class TestYAMLParsing:
     """Tests for YAML configuration parsing."""
 
-    def test_from_yaml_mixed_patterns(self):
+    def test_from_yaml_mixed_patterns(self, temp_yaml_file):
         """Test parsing YAML with various pattern configurations and templates."""
         yaml_content = """
 patterns:
@@ -253,8 +248,8 @@ def test_from_yaml_mixed_patterns(self):
     extract_percall: true
     cumtime_template: "custom_{name}_time"
 """
-        with temp_yaml_file(yaml_content) as yaml_path:
-            config = ExtractionConfig.from_yaml(yaml_path)
+        yaml_path = temp_yaml_file(yaml_content)
+        config = ExtractionConfig.from_yaml(yaml_path)
 
             assert len(config.patterns) == 3
 
@@ -283,46 +278,46 @@ def test_from_yaml_file_not_found(self):
         with pytest.raises(FileNotFoundError, match="YAML config file not found"):
             ExtractionConfig.from_yaml("/nonexistent/file.yaml")
 
-    def test_from_yaml_missing_patterns_key(self):
+    def test_from_yaml_missing_patterns_key(self, temp_yaml_file):
         """Test error when YAML is missing 'patterns' key."""
         yaml_content = """
 some_other_key:
   - value: 1
 """
-        with temp_yaml_file(yaml_content) as yaml_path:
-            with pytest.raises(ValueError, match="must contain a 'patterns' key"):
-                ExtractionConfig.from_yaml(yaml_path)
+        yaml_path = temp_yaml_file(yaml_content)
+        with pytest.raises(ValueError, match="must contain a 'patterns' key"):
+            ExtractionConfig.from_yaml(yaml_path)
 
-    def test_from_yaml_missing_name_field(self):
+    def test_from_yaml_missing_name_field(self, temp_yaml_file):
         """Test error when pattern is missing 'name' field."""
         yaml_content = """
 patterns:
   - filename: test.py
     function_name: test
 """
-        with temp_yaml_file(yaml_content) as yaml_path:
-            with pytest.raises(ValueError, match="missing required field 'name'"):
-                ExtractionConfig.from_yaml(yaml_path)
+        yaml_path = temp_yaml_file(yaml_content)
+        with pytest.raises(ValueError, match="missing required field 'name'"):
+            ExtractionConfig.from_yaml(yaml_path)
 
-    def test_from_yaml_missing_required_fields(self):
+    def test_from_yaml_missing_required_fields(self, temp_yaml_file):
         """Test error when pattern is missing required fields."""
         yaml_content = """
 patterns:
   - name: my_func
     filename: test.py
 """
-        with temp_yaml_file(yaml_content) as yaml_path:
-            with pytest.raises(
-                ValueError, match="requires 'filename' and 'function_name' fields"
-            ):
-                ExtractionConfig.from_yaml(yaml_path)
+        yaml_path = temp_yaml_file(yaml_content)
+        with pytest.raises(
+            ValueError, match="requires 'filename' and 'function_name' fields"
+        ):
+            ExtractionConfig.from_yaml(yaml_path)
 
-    def test_from_yaml_pattern_not_dict(self):
+    def test_from_yaml_pattern_not_dict(self, temp_yaml_file):
         """Test error when pattern is not a dictionary."""
         yaml_content = """
 patterns:
   - not_a_dict
 """
-        with temp_yaml_file(yaml_content) as yaml_path:
-            with pytest.raises(ValueError, match="must be a dictionary"):
-                ExtractionConfig.from_yaml(yaml_path)
+        yaml_path = temp_yaml_file(yaml_content)
+        with pytest.raises(ValueError, match="must be a dictionary"):
+            ExtractionConfig.from_yaml(yaml_path)