change name

Author: patricktnast

src/vivarium_profiling/tools/cli.py

@@ -101,7 +101,7 @@ def make_artifacts(
     help="Drop into python debugger if an error occurs.",
 )
 def run_benchmark(
-    models: tuple[str, ...],
+    model_specifications: tuple[str, ...],
     model_runs: int,
     baseline_model_runs: int,
     output_dir: str,
@@ -117,8 +117,8 @@ def run_benchmark(
         run_benchmark -m "model_spec_baseline.yaml" -m "model_spec_*.yaml" -r 10 -b 20
     """
     # Expand model patterns
-    model_specs = expand_model_specs(list(models))
+    model_specifications = expand_model_specs(list(model_specifications))
 
     # Run benchmarks with error handling
     main = handle_exceptions(run_benchmark_loop, logger, with_debugger=with_debugger)
-    main(model_specs, model_runs, baseline_model_runs, output_dir, verbose)
+    main(model_specifications, model_runs, baseline_model_runs, output_dir, verbose)

src/vivarium_profiling/tools/run_benchmark.py

@@ -245,7 +245,7 @@ def run_single_benchmark(
 
 
 def run_benchmark_loop(
-    model_specs: list[Path],
+    model_specifications: list[Path],
     model_runs: int,
     baseline_model_runs: int,
     output_dir: str = ".",
@@ -274,19 +274,19 @@ def run_benchmark_loop(
     configure_logging_to_terminal(verbose)
 
     # Validate inputs
-    validate_baseline_model(model_specs)
+    validate_baseline_model(model_specifications)
 
     # Create results directory and initialize results file
     results_dir = create_results_directory(output_dir)
     results_file = initialize_results_file(results_dir)
 
     logger.info("Running benchmarks:")
-    logger.info(f"  Model Specs: {model_specs}")
+    logger.info(f"  Model Specs: {model_specifications}")
     logger.info(f"  Runs: {model_runs} ({baseline_model_runs} for baseline)")
     logger.info(f"  Results Directory: {results_dir}")
 
     # Run benchmarks for each specification
-    for spec in model_specs:
+    for spec in model_specifications:
         logger.info(f"Running {spec}...")
 
         model_spec_name = spec.stem

tests/test_run_benchmark.py

@@ -33,7 +33,7 @@ def test_run_benchmark_loop_integration(test_model_specs: list[Path], tmp_path:
 
     # Run the benchmark
     results_dir = run_benchmark_loop(
-        model_specs=test_model_specs,
+        model_specifications=test_model_specs,
         model_runs=model_runs,
         baseline_model_runs=baseline_runs,
         output_dir=output_dir,
@@ -99,7 +99,7 @@ def test_run_benchmark_loop_validation_error(test_model_specs: list[Path], tmp_p
         match="Error: One of the model specs must be 'model_spec_baseline.yaml'.",
     ):  # Should raise ClickException about missing baseline
         run_benchmark_loop(
-            model_specs=model_specs,
+            model_specifications=model_specs,
             model_runs=2,
             baseline_model_runs=2,
             output_dir=output_dir,