Skip to content

Commit 5229f9d

Browse files
authored
Merge pull request #1910 from ihmeuw/no_19
Run request for model 19.0 nutrition optimization / Ethiopian targeted SQ-LNS reruns
2 parents 5322b39 + d977be8 commit 5229f9d

2 files changed

Lines changed: 49 additions & 4 deletions

File tree

docs/source/models/concept_models/vivarium_nutrition_optimization/kids/concept_model.rst

Lines changed: 35 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1526,7 +1526,7 @@ Wave II
15261526
* `MMS effect size update and implementation confirmed to be functioning in interactive sim <https://github.com/ihmeuw/vivarium_research_nutrition_optimization/blob/data_prep/verification_and_validation/child_model/model_12.1.1_interactive_MMS_effect.ipynb>`_
15271527
* - 12.2
15281528
- Check that results for this run approximate the mean of the results from run 12.1
1529-
-
1529+
- [TODO: CONFIRM V&V CONCLUSIONS FROM THIS RUN]
15301530

15311531
.. list-table:: Outstanding V&V issues
15321532
:header-rows: 1
@@ -1625,6 +1625,19 @@ Wave III
16251625
- All
16261626
- National runs
16271627
- Standard SQ-LNS effects only
1628+
* - ``vivarium_v4.0_vph_v5.0_update``
1629+
- Runs that integrate vivarium and vivarium_public_health framework updates to confirm we still meet V&V criteria following these updates
1630+
- Baseline, MMS (run using maternal simulation outputs from the ``vivarium_v4.0_vph_v5.0_update`` model version)
1631+
- Baseline, 8 (all)
1632+
- National runs (informed from subnational artifact). 10 draws (not the mean draw). Nigeria and Pakistan only.
1633+
- Standard SQ-LNS effects only
1634+
* - 19.0
1635+
- Production runs for re-run of model 17 for Ethiopia to resolve subnational scrambling issue
1636+
- Same as model 17.0
1637+
- Same as model 17.0
1638+
- Same as model 17.0
1639+
- This run is to resolve an issue for Ethiopian results in model 17.0 in which data were scrambled across subnational locations (`see details here <https://github.com/ihmeuw/vivarium_research_nutrition_optimization/blob/fea37d5913dca2a65c814decbe3a457d383913b6/emulator/sqlns_targeting/artifact_data_checks.ipynb>`__). New custom data was generated based on an updated Ethiopian artifact without this issue (`see PR here <https://github.com/ihmeuw/vivarium_research_nutrition_optimization/pull/207>`__ and `here <https://github.com/ihmeuw/vivarium_research_nutrition_optimization/pull/212>`__) and updated in the simulation repo (`see PR here <https://github.com/ihmeuw/vivarium_gates_nutrition_optimization_child/pull/197>`__ and `here <https://github.com/ihmeuw/vivarium_gates_nutrition_optimization_child/pull/198>`__). Notably, these runs will be performed in 2026 almost two years after model 17.0 and the exact environments used to run model 19.0 is not expected to exactly match that used to run model 17.0. This model will include Standard and modified SQ-LNS effects.
1640+
16281641

16291642

16301643
.. list-table:: Output specifications
@@ -1723,13 +1736,21 @@ Wave III
17231736
5. Stunting state person time stratified by SQ-LNS coverage
17241737
- * Age group
17251738
* Subnational location (need to determine how this will be "stratified")
1726-
* - 18.0
1739+
* - 18.0, ``vivarium_v4.0_vph_v5.0_update``
1740+
- 1. Deaths and YLLs
1741+
2. YLDs
1742+
3. Count of incident SAM cases stratified by SAM treatment coverage
1743+
4. Count of incident MAM cases stratified by MAM treatment coverage
1744+
5. Stunting state person time stratified by SQ-LNS coverage
1745+
- Age strata of 0-6 months, 6-18 months, 18-60 months
1746+
* - 19.0
17271747
- 1. Deaths and YLLs (non-cause-specific)
17281748
2. YLDs (all-cause observer only)
17291749
3. Count of incident SAM cases stratified by SAM treatment coverage
17301750
4. Count of incident MAM cases stratified by MAM treatment coverage
17311751
5. Stunting state person time stratified by SQ-LNS coverage
1732-
- Age strata of 0-6 months, 6-18 months, 18-60 months
1752+
- * Age strata of 0-6 months, 6-18 months, 18-60 months
1753+
* Results specific to subnational location (in the same manner as model 17.0)
17331754

17341755

17351756
.. list-table:: Verification and validation tracking
@@ -1798,7 +1819,18 @@ Wave III
17981819
* - 17.0
17991820
- * Confirm that results for production runs match expected outputs
18001821
- * As in model 16, we checked the SQ-LNS effects to ensure these matched for both standard, and modifed effects. In general, all subnational locations were within the confidence intervals. The cases where this is untrue and the rationale for approval are noted in the Jupyter notebook here. `Model 17 SQLNS effects <https://github.com/ihmeuw/vivarium_research_nutrition_optimization/blob/0858f98bd9e19f2621873c83a20efef055a0a5d8/verification_and_validation/child_model/model_17.0_sqlns_effects.ipynb>`_.
1822+
* An issue with artifact data used for subnational locations in Ethiopia was identified that necessitates a rerun (`see details here <https://github.com/ihmeuw/vivarium_research_nutrition_optimization/blob/fea37d5913dca2a65c814decbe3a457d383913b6/emulator/sqlns_targeting/artifact_data_checks.ipynb>`__)
1823+
* An issue with the application of modified SQ-LNS effects was identified and `summarized in this PR <https://github.com/ihmeuw/vivarium_research/pull/1902>`__, but deemed an acceptable limitation.
18011824
* - 18.0
18021825
- * Confirm that results for production runs match expected outputs
1826+
- * An issue with artifact data used for subnational locations in Ethiopia was identified that necessitates a rerun (`see details here <https://github.com/ihmeuw/vivarium_research_nutrition_optimization/blob/fea37d5913dca2a65c814decbe3a457d383913b6/emulator/sqlns_targeting/artifact_data_checks.ipynb>`__)
1827+
* Potential issue with mean draw systematically overestimating baseline parameters is expected (TODO: update with notebook demonstrating this issue)
1828+
* TODO: update with links to general V&V notebooks for this run
1829+
* - ``viv4.0_vph_v5.0_update``
1830+
- * Confirm baseline scenario cause burden and CGF risk exposures meets GBD expectation
1831+
* Compare total scenario-specifc (maternal MMS, child scenario 8) DALYs to results from model 18.0
1832+
-
1833+
* - 19.0
1834+
- Re-run model 17.0 V&V for updated Ethiopian locations
18031835
-
18041836

docs/source/models/concept_models/vivarium_nutrition_optimization/pregnancies/concept_model.rst

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,13 @@ Specific outputs for specific models are specified in the following section.
607607
- Same as 9.2 but including count of live births and still births
608608
- Same as 9.2
609609
-
610-
610+
* - ``vivarium_v4.0_vph_v5.0_update``
611+
- Runs that integrate vivarium and vivarium_public_health framework updates to confirm we still meet V&V criteria following these updates
612+
- All
613+
- 10 draws, 10 seeds with 20,000 population (200,000 pregnancies per draw). Nigeria and Pakistan only
614+
- Default
615+
- Default
616+
-
611617

612618
.. note::
613619

@@ -737,6 +743,13 @@ Specific outputs for specific models are specified in the following section.
737743
- `V&V notebooks for model 11.2 can be found here <https://github.com/ihmeuw/vivarium_research_nutrition_optimization/pull/146>`_
738744
* Maternal disorders YLDs now look as expected -- ready to move on to production runs
739745
* Also confirmed that the birth outcome observer is capturing outcomes among all simulated individuals, including those who die during the simulation
746+
* - ``vivarium_v4.0_vph_v5.0_update``
747+
- All V&V checks
748+
- All models are meeting V&V criteria. Notebooks linked below have been updated to support the results management system format as of March 2026, but currently only support a single location at once.
749+
750+
* `Intervention coverage notebook <https://github.com/ihmeuw/vivarium_research_nutrition_optimization/blob/data_prep/verification_and_validation/pregnancy_model/model_viv4.0_intervention_coverage.ipynb>`__
751+
* `Maternal disorders and anemia burden notebook <https://github.com/ihmeuw/vivarium_research_nutrition_optimization/blob/data_prep/verification_and_validation/pregnancy_model/model_viv4.0_maternal_disorders_anemia.ipynb>`__
752+
* `Pregnancy model notebook <https://github.com/ihmeuw/vivarium_research_nutrition_optimization/blob/data_prep/verification_and_validation/pregnancy_model/model_viv4.0_preg_states.ipynb>`__
740753

741754
.. list-table:: Outstanding V&V issues
742755
:header-rows: 1

0 commit comments

Comments
 (0)