refactor: make opentelemetry a required dependency in Python SDK (#1434)

Author: guibeira

sdk/packages/python/iii/pyproject.toml

@@ -22,17 +22,15 @@ classifiers = [
 dependencies = [
     "websockets>=12.0",
     "pydantic>=2.0",
+    "opentelemetry-api>=1.25",
+    "opentelemetry-sdk>=1.25",
 ]
 
 [project.urls]
 Homepage = "https://github.com/iii-hq/sdk"
 Repository = "https://github.com/iii-hq/sdk"
 
 [project.optional-dependencies]
-otel = [
-    "opentelemetry-api>=1.25",
-    "opentelemetry-sdk>=1.25",
-]
 dev = [
     "pytest>=8.0",
     "pytest-asyncio>=0.23",
@@ -41,8 +39,6 @@ dev = [
     "aiohttp>=3.9",
     "mypy>=1.8",
     "ruff>=0.2",
-    "opentelemetry-api>=1.25",
-    "opentelemetry-sdk>=1.25",
     "griffe>=1.0",
 ]
 

sdk/packages/python/iii/src/iii/iii.py

@@ -186,20 +186,17 @@ async def connect_async(self) -> None:
         from an async context.
         """
         self._running = True
-        try:
-            from .telemetry import attach_event_loop, init_otel
-
-            loop = asyncio.get_running_loop()
-            otel_cfg: OtelConfig | None = None
-            if self._options.otel:
-                if isinstance(self._options.otel, OtelConfig):
-                    otel_cfg = self._options.otel
-                else:
-                    otel_cfg = OtelConfig(**self._options.otel)
-            init_otel(config=otel_cfg, loop=loop)
-            attach_event_loop(loop)
-        except ImportError:
-            log.debug("OpenTelemetry not available")
+        from .telemetry import attach_event_loop, init_otel
+
+        loop = asyncio.get_running_loop()
+        otel_cfg: OtelConfig | None = None
+        if self._options.otel:
+            if isinstance(self._options.otel, OtelConfig):
+                otel_cfg = self._options.otel
+            else:
+                otel_cfg = OtelConfig(**self._options.otel)
+        init_otel(config=otel_cfg, loop=loop)
+        attach_event_loop(loop)
         self._set_connection_state("connecting")
         await self._do_connect()
 
@@ -238,12 +235,9 @@ async def shutdown_async(self) -> None:
 
         self._set_connection_state("disconnected")
 
-        try:
-            from .telemetry import shutdown_otel_async
+        from .telemetry import shutdown_otel_async
 
-            await shutdown_otel_async()
-        except ImportError:
-            log.debug("OpenTelemetry not available")
+        await shutdown_otel_async()
 
         # Schedule the event loop to stop on the next iteration so the
         # non-daemon background thread exits and the process can terminate.
@@ -418,26 +412,20 @@ def _handle_result(self, invocation_id: str, result: Any, error: Any) -> None:
             future.set_result(result)
 
     def _inject_traceparent(self) -> str | None:
-        try:
-            from opentelemetry import context as otel_context
-            from opentelemetry import propagate
+        from opentelemetry import context as otel_context
+        from opentelemetry import propagate
 
-            carrier: dict[str, str] = {}
-            propagate.inject(carrier, context=otel_context.get_current())
-            return carrier.get("traceparent")
-        except ImportError:
-            return None
+        carrier: dict[str, str] = {}
+        propagate.inject(carrier, context=otel_context.get_current())
+        return carrier.get("traceparent")
 
     def _inject_baggage(self) -> str | None:
-        try:
-            from opentelemetry import context as otel_context
-            from opentelemetry import propagate
+        from opentelemetry import context as otel_context
+        from opentelemetry import propagate
 
-            carrier: dict[str, str] = {}
-            propagate.inject(carrier, context=otel_context.get_current())
-            return carrier.get("baggage")
-        except ImportError:
-            return None
+        carrier: dict[str, str] = {}
+        propagate.inject(carrier, context=otel_context.get_current())
+        return carrier.get("baggage")
 
     async def _invoke_with_otel_context(
         self,
@@ -446,16 +434,8 @@ async def _invoke_with_otel_context(
         traceparent: str | None,
         baggage: str | None,
     ) -> tuple[Any, str | None]:
-        try:
-            from opentelemetry import context as otel_context
-            from opentelemetry import propagate, trace
-
-            otel_available = True
-        except ImportError:
-            otel_available = False
-
-        if not otel_available:
-            return await handler(data), None
+        from opentelemetry import context as otel_context
+        from opentelemetry import propagate, trace
 
         carrier: dict[str, str] = {}
         if traceparent:

sdk/packages/python/iii/src/iii/logger.py

@@ -18,12 +18,9 @@
 
 def is_initialized() -> bool:
     """Return True if OTel has been initialized (importable without circular dep)."""
-    try:
-        from .telemetry import is_initialized as _is_init
+    from .telemetry import is_initialized as _is_init
 
-        return _is_init()
-    except ImportError:
-        return False
+    return _is_init()
 
 
 class Logger: