added test step to github workflow

Author: ivankatliarchuk

.github/workflows/nodejs.yaml

@@ -24,12 +24,17 @@ jobs:
     - run: npm run build --if-present
     - run: npm run local
       env:
-        DEBUG: INFO
+        LOG_LEVEL: WARN
         NODE_ENV: production
         REGION: eu-west-1
     - run: npm run local
       env:
-        DEBUG: DEBUG
+        LOG_LEVEL: DEBUG
+        NODE_ENV: production
+        REGION: us-west-1
+    - run: npm test
+      env:
+        LOG_LEVEL: ERROR
         NODE_ENV: production
         REGION: us-west-1
     - name: define version

Makefile

@@ -1,6 +1,8 @@
+.ONESHELL:
 .EXPORT_ALL_VARIABLES:
+.PHONY: pre-commit changelog release test
 
-.PHONY: pre-commit changelog release
+SHELL := /bin/bash
 
 help:
 	@grep -E '^[a-zA-Z0-9_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
@@ -17,4 +19,14 @@ changelog: ## Update changelog
 	git-chglog -o CHANGELOG.md --next-tag `semtag final -s minor -o`
 
 release: ## Create release version
-	semtag final -s minor
+	semtag final -s minor
+
+validatejs: ## Validate solution
+	@npm run dev:install
+	@npm run format
+	@npm run lint
+
+test: LOG_LEVEL=ERROR
+test: ## Test solution
+	$(if ${LOG_LEVEL},,$(error Must pass LOG_LEVEL=<DEBUG|INFO|WARN|ERROR>))
+	@npm test

package.json

@@ -6,15 +6,15 @@
   "scripts": {
     "build": "tsc -p tsconfig.build.json",
     "format": "prettier --write \"src/**/*.ts\"",
-    "lint": "tslint --project tsconfig.json",
+    "lint": "tslint --project tsconfig.build.json",
     "pretest": "npm run lint",
     "all": "npm run build && npm prune --production && rm -f dist/lambda.zip && zip -q -r dist/lambda.zip node_modules dist && npm ci",
-    "testt": "mocha -r ts-node/register test/**/*.spec.ts",
+    "test": "mocha --colors -r ts-node/register test/**/*.spec.ts",
     "start": "tsc && node dist/index.js",
     "local": "tsc -p tsconfig.build.json && npm run 001",
     "dev:install": "npm install --only=dev && npm install",
     "prod:install": "npm install --production",
-    "001": "./node_modules/.bin/lambda-local -f dist/index -e '{\"json\":\"here\"}'"
+    "001": "./node_modules/.bin/lambda-local -f dist/index -e test/fixtures/sns.event.json"
   },
   "keywords": [
     "aws",

src/config.ts

@@ -1,18 +1,17 @@
 import * as env from 'env-var';
 
 const NODE_ENV: string = env
-  .get('NODE_ENV')
-  .required()
+  .get('NODE_ENV', 'development')
   .asString();
 
 const REGION: string = env
   .get('REGION')
   .required()
   .asString();
 
-const DEBUG: string = env
-  .get('DEBUG')
+const LOG_LEVEL: string = env
+  .get('LOG_LEVEL')
   .required()
   .asString();
 
-export { NODE_ENV, REGION, DEBUG };
+export { NODE_ENV, REGION, LOG_LEVEL };

src/index.ts

@@ -1,26 +1,24 @@
+import Log from '@dazn/lambda-powertools-logger';
 import { Handler } from 'aws-lambda';
-import moment from 'moment';
 import middy from 'middy';
-import Log from '@dazn/lambda-powertools-logger';
+import moment from 'moment';
 
-import { NODE_ENV } from './config';
+import { LambdaResponse } from './utils';
 
 Log.debug('lambda executing...');
 
-export const handler: Handler = middy(
-  async (event: any): Promise<any> => {
-    Log.info(`Event: ${JSON.stringify(event)}.`);
-    let hw: string = 'Hello Dummy Function';
-    Log.info(`${hw}. Environment: ${NODE_ENV}`);
-    Log.info(
-      `event ${JSON.stringify(event)}`,
-    );
+export const lambdahandler: Handler = async (event: any): Promise<LambdaResponse> => {
+  Log.debug(`Event: ${ JSON.stringify(event) }.`);
+  const hw: string = 'Dummy Function';
+  Log.debug(`${ hw }`);
+
+  return {
+    statusCode: 200,
+    body: JSON.stringify({
+      time: moment.utc().toISOString(),
+      records: event.Records.length,
+    }),
+  };
+};
 
-    return {
-      statusCode: 200,
-      body: JSON.stringify({
-        time: moment.utc().toISOString(),
-      }),
-    };
-  },
-);
+export const handler: Handler = middy(lambdahandler);

src/utils.ts

@@ -1,8 +1,8 @@
-interface Response {
+interface LambdaResponse {
   statusCode: number;
   body: string;
 }
 
 export {
-  Response
+  LambdaResponse,
 };

test/fixtures/defait.message.event.json

@@ -0,0 +1,22 @@
+{
+  "Records": [
+    {
+      "EventSource": "aws:sns",
+      "EventVersion": "1.0",
+      "EventSubscriptionArn": "arn:aws:sns:region:account:sns-name:uuid",
+      "Sns": {
+        "Type": "Notification",
+        "MessageId": "",
+        "TopicArn": "arn:aws:sns:region:account:sns-name",
+        "Subject": "ALARM: \"cpu-utilization-low\" in US West (N. California)",
+        "Message": "{ \"AlarmName\":\"cpu-utilization-low\" }",
+        "Timestamp": "2020-01-19T09:09:41.459Z",
+        "SignatureVersion": "1",
+        "Signature": "",
+        "SigningCertUrl": "",
+        "UnsubscribeUrl": "",
+        "MessageAttributes": {}
+      }
+    }
+  ]
+}