forked from linux-nvme/nvme-cli
-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
<https://github.com/linux-nvme/nvme-cli/pull/2817#issuecomment-2890843160>
I was wonder about the second patch how we deal with the verbose flag and json. it seems in most cases we are actually replace the output with something else. So the verbose flag is not extending the existing output.
I think it would make more sense to handle it as we do it in the stdout case, where we leave the orignal output and just extend it.
Though this is something we should do in a different patch and verify that we don't break anyone.
I am fine with the second patch for the time being.
Metadata
Metadata
Assignees
Labels
No labels