Skip to content

verbose flag and json as stdout case #31

@ikegami-t

Description

@ikegami-t
<https://github.com/linux-nvme/nvme-cli/pull/2817#issuecomment-2890843160>
I was wonder about the second patch how we deal with the verbose flag and json. it seems in most cases we are actually replace the output with something else. So the verbose flag is not extending the existing output.

I think it would make more sense to handle it as we do it in the stdout case, where we leave the orignal output and just extend it.

Though this is something we should do in a different patch and verify that we don't break anyone.

I am fine with the second patch for the time being.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions