Skip to content

Commit 4820f26

Browse files
committed
refactor(landing): remove kview-era placeholder cruft; promote dataset
Remove the inert notifications block (fake (4) count, dead SEE ALL NOTIFICATIONS button, single-item filter, 4 static sample cards with broken image paths), the inert sidebar items (Favorites/Comments/Notifications + hardcoded counter), and the inert header ? help icon. Drop the orphaned notification-*/validation-*/all-notification-button CSS rules and the unused ComboBox field and import. Reflow the SplitPane so the journal grid sits directly under the header. Make the Dataset prominent (18px, bold) and move it above the still-wired GitHub Status. Refs: IKE-Network/ike-issues#614
1 parent f6ecebc commit 4820f26

3 files changed

Lines changed: 14 additions & 306 deletions

File tree

kview/src/main/java/dev/ikm/komet/kview/mvvm/view/landingpage/LandingPageController.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@
9090
import javafx.scene.Parent;
9191
import javafx.scene.control.Button;
9292
import javafx.scene.control.ButtonBase;
93-
import javafx.scene.control.ComboBox;
9493
import javafx.scene.control.Hyperlink;
9594
import javafx.scene.control.Label;
9695
import javafx.scene.control.ScrollPane;
@@ -180,9 +179,6 @@ public class LandingPageController implements BasicController {
180179
@FXML
181180
BorderPane landingPageBorderPane;
182181

183-
@FXML
184-
ComboBox<String> notificationTypeFilterComboBox;
185-
186182
@FXML
187183
private Label knowledgeLayoutButtonLabel;
188184

@@ -206,9 +202,6 @@ public void initialize() {
206202

207203
knowledgeLayoutButtonLabel.setText("Knowledge\nLayout Editor");
208204

209-
notificationTypeFilterComboBox.getItems().addAll("All types");
210-
notificationTypeFilterComboBox.getSelectionModel().selectFirst();
211-
212205
progressPopupPane.getStyleClass().add("progress-popup-pane");
213206

214207
LOG.debug("Event bus instance %s, %s".formatted(this.getClass().getSimpleName(), landingPageEventBus));

kview/src/main/resources/dev/ikm/komet/kview/mvvm/view/kview.css

Lines changed: 4 additions & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -3822,6 +3822,7 @@ Timeline Year line segment (will overlay change circles)
38223822

38233823
.welcome-container > .status-pane .status-label.dataset {
38243824
-fx-text-fill: -Secondary-06;
3825+
-fx-font-size: 18px;
38253826
}
38263827

38273828
.welcome-container > .status-pane .github-status-link {
@@ -3836,9 +3837,9 @@ Timeline Year line segment (will overlay change circles)
38363837
}
38373838

38383839
.welcome-container .selected-dataset-title-label {
3839-
-fx-font-family: "Noto Sans Medium";
3840-
-fx-font-weight: 500;
3841-
-fx-font-size: 14px;
3840+
-fx-font-family: "Noto Sans SemiBold";
3841+
-fx-font-weight: 700;
3842+
-fx-font-size: 18px;
38423843
-fx-text-fill: -Secondary-06;
38433844
}
38443845

@@ -3868,24 +3869,6 @@ Timeline Year line segment (will overlay change circles)
38683869
.notification-container {
38693870
-fx-spacing: 8;
38703871
}
3871-
/* notification section hbox > region dropdown button*/
3872-
.notification-title-icon {
3873-
-fx-pref-width: 20px;
3874-
-fx-max-width: 20;
3875-
-fx-pref-height: 20px;
3876-
-fx-max-height: 20px;
3877-
-fx-background-color: -Grey-Black;
3878-
-fx-shape: "M19 17V11.8C18.5 11.9 18 12 17.5 12H17V18H7V11C7 8.2 9.2 6 12 6C12.1 4.7 12.7 3.6 13.5 2.7C13.2 2.3 12.6 2 12 2C10.9 2 10 2.9 10 4V4.3C7 5.2 5 7.9 5 11V17L3 19V20H21V19L19 17ZM10 21C10 22.1 10.9 23 12 23C13.1 23 14 22.1 14 21H10ZM21 6.5C21 8.4 19.4 10 17.5 10C15.6 10 14 8.4 14 6.5C14 4.6 15.6 3 17.5 3C19.4 3 21 4.6 21 6.5Z";
3879-
/*-fx-background-insets: -1, 0;*/
3880-
}
3881-
.notification-title {
3882-
-fx-text-fill: -Grey-11;
3883-
-fx-font-family: Noto Sans;
3884-
-fx-font-size: 16px;
3885-
-fx-font-style: normal;
3886-
-fx-font-weight: 600;
3887-
-fx-max-width: 1728px;
3888-
}
38893872

38903873

38913874
.landing-container .combo-box > .list-cell {
@@ -3957,22 +3940,6 @@ Timeline Year line segment (will overlay change circles)
39573940
}
39583941

39593942

3960-
.notification-card-container.scroll-pane,
3961-
.notification-card-container.scroll-pane:focused {
3962-
-fx-pref-height: 196px;
3963-
-fx-background-color: -Grey-3;
3964-
-fx-background-insets: 0;
3965-
-fx-background-radius: 0;
3966-
-fx-padding: 0;
3967-
}
3968-
.notification-card-container.scroll-pane > .viewport,
3969-
.notification-card-container.scroll-pane:focused > .viewport {
3970-
-fx-pref-height: 196px;
3971-
-fx-background-color: -Grey-3;
3972-
-fx-background-insets: 0;
3973-
-fx-background-radius: 0;
3974-
-fx-padding: 0;
3975-
}
39763943
.card {
39773944
-fx-background-radius: 8px;
39783945
-fx-background-color: -Grey-White;
@@ -4227,11 +4194,6 @@ Styling a context menu for kview ui/ux controls
42274194
-fx-shape: "M9.00008 0.666504C4.40758 0.666504 0.666748 4.40733 0.666748 8.99984C0.666748 13.5923 4.40758 17.3332 9.00008 17.3332C13.5926 17.3332 17.3334 13.5923 17.3334 8.99984C17.3334 4.40733 13.5926 0.666504 9.00008 0.666504ZM9.00008 2.33317C12.6919 2.33317 15.6667 5.30807 15.6667 8.99984C15.6667 12.6916 12.6919 15.6665 9.00008 15.6665C5.30831 15.6665 2.33341 12.6916 2.33341 8.99984C2.33341 5.30807 5.30831 2.33317 9.00008 2.33317ZM8.16675 4.83317V8.1665H4.83342V9.83317H8.16675V13.1665H9.83342V9.83317H13.1667V8.1665H9.83342V4.83317H8.16675Z"
42284195
}
42294196

4230-
.notification-card {
4231-
-fx-pref-width: 280px;
4232-
-fx-pref-height: 178px;
4233-
}
4234-
42354197
.journal-project-card {
42364198
-default-width: 280px;
42374199
-default-height: 226px;
@@ -4243,21 +4205,6 @@ Styling a context menu for kview ui/ux controls
42434205
-fx-max-height: -default-height;
42444206
}
42454207

4246-
/* region svg shape of an X to close card */
4247-
.notification-card .close-button {
4248-
-fx-background-radius: 4px;
4249-
-fx-background-insets: 0;
4250-
-fx-background-color: -Grey-8;
4251-
-fx-padding: 4;
4252-
4253-
-width-size: 12px;
4254-
-height-size: 12px;
4255-
-fx-min-height: -height-size;
4256-
-fx-min-width: -width-size;
4257-
-fx-max-height: -height-size;
4258-
-fx-max-width: -width-size;
4259-
-fx-shape: "M15.8334 5.3415L14.6584 4.1665L10.0001 8.82484L5.34175 4.1665L4.16675 5.3415L8.82508 9.99984L4.16675 14.6582L5.34175 15.8332L10.0001 11.1748L14.6584 15.8332L15.8334 14.6582L11.1751 9.99984L15.8334 5.3415Z";
4260-
}
42614208
/* Contains the card's info VBox */
42624209
.card-info-container {
42634210
/*-fx-padding: 12px 16px;*/
@@ -4270,35 +4217,10 @@ Styling a context menu for kview ui/ux controls
42704217
-fx-font-style: normal;
42714218
-fx-font-weight: 500;
42724219
}
4273-
.card-info-container .validation-counts {
4274-
-fx-text-fill: -Grey-12;
4275-
-fx-font-family: Noto Sans;
4276-
-fx-font-size: 25px;
4277-
-fx-font-style: normal;
4278-
-fx-font-weight: 500;
4279-
}
4280-
.card-info-container .validation-message {
4281-
-fx-text-fill: -Grey-12;
4282-
-fx-font-family: Noto Sans;
4283-
-fx-font-size: 13px;
4284-
-fx-font-style: normal;
4285-
-fx-font-weight: 400;
4286-
}
4287-
.card-info-container .edit-info-container {
4288-
-fx-spacing: 6px;
4289-
}
42904220
.card-info-container .icon.avatar {
42914221
-fx-background-color: -Secondary-05;
42924222
}
42934223

4294-
.card-info-container .last-user-edit {
4295-
-fx-font-family: Noto Sans;
4296-
-fx-font-size: 11px;
4297-
-fx-font-style: normal;
4298-
-fx-font-weight: 500;
4299-
-fx-text-fill: -Grey-11;
4300-
}
4301-
43024224
.card-info-container .edit-time {
43034225
-fx-font-family: Noto Sans;
43044226
-fx-font-size: 11px;
@@ -4336,15 +4258,6 @@ Styling a context menu for kview ui/ux controls
43364258
-fx-background-radius: 4;
43374259
}
43384260

4339-
/* All notification button on landing page */
4340-
.landing-container .button.all-notification-button {
4341-
-fx-background-color: -Secondary-05, -Grey-2;
4342-
}
4343-
4344-
.landing-container .button.all-notification-button:hover {
4345-
-fx-background-color: -Secondary-04, -Grey-1;
4346-
-fx-text-fill: -Secondary-04;
4347-
}
43484261

43494262
.add-symbol {
43504263
-fx-shape: "M16.6666 10.8334H10.8333V16.6667H9.16665V10.8334H3.33331V9.16671H9.16665V3.33337H10.8333V9.16671H16.6666V10.8334Z";

0 commit comments

Comments
 (0)