address code review: move imports to top-level, add explicit table_info/table_id assertions

Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>

Author: Copilot

fremorizer/tests/test_cmor_run_subtool.py

@@ -14,6 +14,7 @@
 import pytest
 
 from fremorizer import cmor_run_subtool
+from fremorizer.tests.conftest import _CMIP6_EXP_CONFIG_DATA
 
 
 # where are we? we're running pytest from the base directory of this repo
@@ -378,7 +379,6 @@ def test_exp_config_cleanup():
     session-scoped conftest fixture — so we rewrite it from the canonical
     fixture data instead of running ``git restore``.
     '''
-    from fremorizer.tests.conftest import _CMIP6_EXP_CONFIG_DATA  # pylint: disable=import-outside-toplevel
     Path(EXP_CONFIG).write_text(json.dumps(_CMIP6_EXP_CONFIG_DATA, indent=4))
 
 def test_cmor_run_subtool_raise_value_error():

fremorizer/tests/test_cmor_run_subtool_cmip7.py

@@ -97,6 +97,12 @@ def _assert_metadata_matches(ds_in, ds_out):
         assert required_attr in ds_out.ncattrs(), \
             f"CMOR output missing required global attribute '{required_attr}'"
 
+    # CMIP7 uses 'table_info' instead of 'table_id'
+    assert 'table_info' in ds_out.ncattrs(), \
+        "CMOR output missing 'table_info' attribute (CMIP7-specific)"
+    assert 'table_id' not in ds_out.ncattrs(), \
+        "CMOR output should not have 'table_id' for CMIP7 (uses 'table_info' instead)"
+
     # science variable standard_name and long_name must be preserved
     assert ds_in.variables['sos'].standard_name == ds_out.variables['sos'].standard_name, \
         "sos standard_name differs between input and CMOR output"

fremorizer/tests/test_cmor_run_subtool_further_examples.py

@@ -4,6 +4,7 @@
 
 from datetime import date
 import glob
+import json
 import os
 from pathlib import Path
 import shutil
@@ -12,6 +13,7 @@
 import pytest
 
 from fremorizer import cmor_run_subtool
+from fremorizer.tests.conftest import _CMIP6_EXP_CONFIG_DATA
 
 
 # global consts for these tests, with no/trivial impact on the results
@@ -185,6 +187,4 @@ def test_exp_config_cleanup():
     session-scoped conftest fixture — so we rewrite it from the canonical
     fixture data instead of running ``git restore``.
     '''
-    import json  # pylint: disable=import-outside-toplevel
-    from fremorizer.tests.conftest import _CMIP6_EXP_CONFIG_DATA  # pylint: disable=import-outside-toplevel
     Path(EXP_CONFIG_DEFAULT).write_text(json.dumps(_CMIP6_EXP_CONFIG_DATA, indent=4))