Conversation
Member
Copilot
AI
changed the title
[WIP] Fix create_test_conda_env not working
Fix create_test_conda_env: isolate version from heavy imports, add submodules, fix test issues
Apr 14, 2026
- Move __version__ to _version.py to avoid importing cmor during pip build - Update pyproject.toml to read version from fremorizer._version - Add submodules: recursive to checkout step in workflow - Add nccmp to environment.yaml (needed by tests) - Fix test_find_statics_file_success to use tmp_path (avoid test pollution) - Fix test_setup_fre_cmor_run_subtool to create output directory Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/9d29eafc-3795-4808-ba85-95ab00fa460f Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
- Replace 4 nccmp subprocess calls with netCDF4-based Python assertions - Add _assert_data_matches() and _assert_metadata_matches() helpers - Add CMIP6_REQUIRED_GLOBAL_ATTRS constant for metadata validation - Remove nccmp from environment.yaml - Remove nccmp from .cspell/ok-unknown-words.txt - Update PHASE_2.5_EQUIVALENCE_TESTING.md to remove nccmp reference - Mark Phase 3 item 1 as complete in PHASE_3_DEFERRED_FEATURES.md Adapted from fre-cli PR #826. Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/60372479-3053-4bc3-ae84-1bdc0a048e2d Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
ilaflott
force-pushed
the
copilot/fix-create-test-conda-env
branch
from
32e6a7c to
b2f388f
Compare
Member
|
winner winner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nccmpsubprocess calls withnetCDF4-based comparisons intest_cmor_run_subtool.py(adapted from fre-cli PR #826)netCDF4/numpyimports andCMIP6_REQUIRED_GLOBAL_ATTRSconstant_assert_data_matches()and_assert_metadata_matches()helper functionsnccmpfromenvironment.yamlnccmpfrom.cspell/ok-unknown-words.txtPHASE_2.5_EQUIVALENCE_TESTING.mdto removenccmpreferencePHASE_3_DEFERRED_FEATURES.mdto mark item 1 as complete