migrate fre/tests/test_fre_cmor_cli.py → fremorizer/tests/test_cli.py#62
Merged
migrate fre/tests/test_fre_cmor_cli.py → fremorizer/tests/test_cli.py#62
Conversation
Copilot
AI
changed the title
[WIP] Migrate NOAA-GFDL/fre-cli tests to fremorizer repository
migrate fre/tests/test_fre_cmor_cli.py → fremorizer/tests/test_cli.py
Apr 14, 2026
ilaflott
force-pushed
the
copilot/migrate-fre-cli-tests
branch
from
0f0bdde to
0964fee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #62 +/- ##
===========================================
+ Coverage 76.81% 93.74% +16.93%
===========================================
Files 9 9
Lines 1199 1199
===========================================
+ Hits 921 1124 +203
+ Misses 278 75 -203 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/b3e2e5fd-8756-4389-b553-f71f955e495b Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/b3e2e5fd-8756-4389-b553-f71f955e495b Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…ttern Fixes: - test_cli_fremor: click>=8.2 returns exit_code=2 for group with no subcommand - log tests: use 'yaml --help' so group callback runs before click processes --help - run/varlist tests: use session-scoped conftest fixtures for NC file generation - run/varlist tests: use tmp_path for outputs instead of shared directories - config test: depend on cli_sos_nc_file fixture - find tests: use Path objects from conftest instead of string concatenation Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/8457b2f7-ba78-41c0-b74e-2ec0575b97d9 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Addresses code review feedback: - Use tmp_path for log file isolation - Extract LOG_INFO_LINE and LOG_DEBUG_LINE as module-level constants Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/8457b2f7-ba78-41c0-b74e-2ec0575b97d9 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/8457b2f7-ba78-41c0-b74e-2ec0575b97d9 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
ilaflott
force-pushed
the
copilot/migrate-fre-cli-tests
branch
from
4569cd3 to
f2a7038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fremorizer/tests/test_cli.py(migrated from fre-cli)test_cli.py:conftest.pywith session-scoped fixtures for NC file generationtest_cli_fremor: click>=8.2 returns exit_code=2yaml --helpsubcommand, tmp_path, extracted constantstest_setup_test_files: use conftest fixtures