Skip to content

Improve variable list semantics for MIP table names#74

Merged
ilaflott merged 14 commits intomainfrom
copilot/update-variable-list-handling
Apr 23, 2026
Merged

Improve variable list semantics for MIP table names#74
ilaflott merged 14 commits intomainfrom
copilot/update-variable-list-handling

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

  • Port variable list semantics (local_var for file/data, target_var for MIP lookup)
  • Fix omission tracking clash in CLI (only raise on result < 0)
  • Propagate new semantics to fremor varlist (non-MIP vars get empty string value)
  • Fix test_cli_fremor_run_cmip7_case3: grid_label g99g999 (g99 is not a valid CMIP7 CV grid label)
  • Fix test_make_simple_varlist_mip_table_no_match: update assertion for new semantics (non-MIP vars now included with '' value instead of filtered out)
  • Fix test_fre_cmor_run_subtool_cmip7_case2 setup: use netCDF4 to copy+rename sossosV2 so local_var matches variable name in file
  • Update _assert_data_matches/_assert_metadata_matches helpers to accept in_var_name param for case2 (input has sosV2, output has sos)

ian: also:

  • add Contributors to README.md
  • add SECURITY.md
  • quote-consistency according to pylint
  • a CMIP7 test that did not run before now runs (gppLut in CMIP7_land)
  • adjust version from 0.1.2 to 0.9.0 for tagged release, set to 0.9.0post after publish workflow

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fremorizer/cmor_finder.py 71.42% 2 Missing ⚠️
fremorizer/cli.py 66.66% 1 Missing ⚠️
fremorizer/cmor_mixer.py 90.90% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   95.19%   94.68%   -0.51%     
==========================================
  Files          10       10              
  Lines        1310     1317       +7     
==========================================
  Hits         1247     1247              
- Misses         63       70       +7     
Files with missing lines Coverage Δ
fremorizer/_version.py 100.00% <100.00%> (ø)
fremorizer/cli.py 99.05% <66.66%> (-0.95%) ⬇️
fremorizer/cmor_mixer.py 91.66% <90.90%> (-0.37%) ⬇️
fremorizer/cmor_finder.py 95.69% <71.42%> (-4.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d71ad0...34bf0fa. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot stopped work on behalf of ilaflott due to an error April 14, 2026 18:12
Copilot AI requested a review from ilaflott April 14, 2026 18:12
@ilaflott ilaflott marked this pull request as ready for review April 14, 2026 18:13
@ilaflott ilaflott force-pushed the copilot/update-variable-list-handling branch from 795cd08 to 9a94bec Compare April 14, 2026 18:15
@ilaflott ilaflott changed the title [WIP] Improve variable list semantics for MIP table names Improve variable list semantics for MIP table names Apr 17, 2026
@ilaflott ilaflott force-pushed the copilot/update-variable-list-handling branch 2 times, most recently from d363bc8 to 9807b94 Compare April 22, 2026 21:22
@ilaflott ilaflott force-pushed the copilot/update-variable-list-handling branch from 9807b94 to a34252a Compare April 22, 2026 21:56
@ilaflott ilaflott merged commit 7915aba into main Apr 23, 2026
14 of 18 checks passed
@ilaflott ilaflott deleted the copilot/update-variable-list-handling branch April 24, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new features: Variable list semantics (map modeler vars to MIP table names)

3 participants