Merge pull request #114 from marcellourbani/optional-https-agent---partially-fixes-#106

Author: iljapostnovs

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.9.0 (06-06-2025)
+
+-   validate TLS connections by default (rejectUnauthorized=true)
+-   improved proxy support (use custom agent only when not validating TLS connections)
+
 ## 1.8.2 (16-04-2025)
 
 -   fix parser config handler

README.md

@@ -77,7 +77,7 @@ Default `package.json` or `rc` file config looks as follows:
 			// Source for standard library metadata preload
 			"dataSource": "https://ui5.sap.com/",
 			// For HTTP requests to dataSource
-			"rejectUnauthorized": false,
+			"rejectUnauthorized": true,
 			// List of libraries to be loaded
 			"libsToLoad": [
 				"sap.m",

package-lock.json

@@ -1,6 +1,6 @@
 {
 	"name": "ui5plugin-parser",
-	"version": "1.8.2",
+	"version": "1.9.0",
 	"description": "UI5 Class parser",
 	"main": "dist/index.js",
 	"scripts": {
@@ -67,4 +67,4 @@
 		"rc-config-loader": "^4.1.3",
 		"ts-morph": "^25.0.1"
 	}
-}
+}

package.json

@@ -152,7 +152,7 @@ export class PackageParserConfigHandler implements IParserConfigHandler {
 		return (
 			this._config?.ui5?.ui5parser?.rejectUnauthorized ??
 			PackageParserConfigHandler._globalConfig?.ui5?.ui5parser?.rejectUnauthorized ??
-			false
+			true
 		);
 	}
 

src/classes/config/PackageParserConfigHandler.ts

@@ -12,10 +12,7 @@ export class HTTPHandler {
 		let data = {};
 
 		const rejectUnauthorized = this.configHandler.getRejectUnauthorized();
-		const agent = new https.Agent({
-			rejectUnauthorized: !!rejectUnauthorized
-		});
-		options.httpsAgent = agent;
+		if (!rejectUnauthorized) options.httpsAgent = new https.Agent({ rejectUnauthorized: !!rejectUnauthorized });
 
 		try {
 			if (HTTPHandler._requests[uri]) {