fixing transaction management unit test problem

Author: greyWizardCode

ECommerce.BusinessEvents.Tests/Services/EventTrackingServiceTests.cs

@@ -6,6 +6,7 @@
 using Moq;
 using ECommerce.Contracts.DTOs;
 using ECommerce.Contracts.Interfaces;
+using ECommerce.BusinessEvents.Infrastructure;
 
 namespace ECommerce.BusinessEvents.Tests.Services
 {
@@ -15,6 +16,7 @@ public class EventTrackingServiceTests : IDisposable
         private readonly SchemaRegistryService _schemaRegistry;
         private readonly Mock<IJsonSchemaValidator> _schemaValidatorMock;
         private readonly EventTrackingService _eventTracker;
+        private readonly ITransactionManager _transactionManager;
 
         public EventTrackingServiceTests()
         {
@@ -26,7 +28,8 @@ public EventTrackingServiceTests()
             _schemaRegistry = new SchemaRegistryService(_context);
             _schemaValidatorMock = new Mock<IJsonSchemaValidator>();
             var loggerMock = new Mock<Microsoft.Extensions.Logging.ILogger<EventTrackingService>>();
-            _eventTracker = new EventTrackingService(_context, _schemaRegistry, _schemaValidatorMock.Object, loggerMock.Object);
+            _transactionManager = new NoOpTransactionManager();
+            _eventTracker = new EventTrackingService(_context, _schemaRegistry, _schemaValidatorMock.Object, loggerMock.Object, _transactionManager);
 
             InitializeTestSchema().Wait();
         }

ECommerce.BusinessEvents/BusinessEventsModule.cs

@@ -1,3 +1,4 @@
+using ECommerce.BusinessEvents.Infrastructure;
 using ECommerce.BusinessEvents.Infrastructure.Validators;
 using ECommerce.BusinessEvents.Persistence;
 using ECommerce.BusinessEvents.Services;
@@ -39,6 +40,11 @@ public static IServiceCollection AddBusinessEventsModule(this IServiceCollection
 
             // Register SchemaRegistryService
             services.AddScoped<SchemaRegistryService>();
+            services.AddScoped<ITransactionManager, EfCoreTransactionManager>(sp =>
+            {
+                var dbContext = sp.GetRequiredService<BusinessEventDbContext>();
+                return new EfCoreTransactionManager(dbContext);
+            });
             services.AddScoped<IBusinessEventService, EventTrackingService>();
             services.AddScoped<IJsonSchemaValidator, JsonSchemaValidator>();
             services.AddScoped<IEventRetrievalService>(sp =>

ECommerce.BusinessEvents/Infrastructure/EfCoreTransactionManager.cs

@@ -0,0 +1,40 @@
+using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore.Storage;
+
+namespace ECommerce.BusinessEvents.Infrastructure
+{
+    public class EfCoreTransactionManager : ITransactionManager
+    {
+        private readonly DbContext _dbContext;
+        private IDbContextTransaction? _transaction;
+
+        public EfCoreTransactionManager(DbContext dbContext)
+        {
+            _dbContext = dbContext;
+        }
+
+        public async Task BeginTransactionAsync()
+        {
+            _transaction = await _dbContext.Database.BeginTransactionAsync();
+        }
+
+        public async Task CommitAsync()
+        {
+            if (_transaction != null)
+                await _transaction.CommitAsync();
+        }
+
+        public async Task RollbackAsync()
+        {
+            if (_transaction != null)
+                await _transaction.RollbackAsync();
+        }
+
+        public async ValueTask DisposeAsync()
+        {
+            if (_transaction != null)
+                await _transaction.DisposeAsync();
+        }
+    }
+}
+

ECommerce.BusinessEvents/Infrastructure/ITransactionManager.cs

@@ -0,0 +1,13 @@
+using System;
+using System.Threading.Tasks;
+
+namespace ECommerce.BusinessEvents.Infrastructure
+{
+    public interface ITransactionManager : IAsyncDisposable
+    {
+        Task BeginTransactionAsync();
+        Task CommitAsync();
+        Task RollbackAsync();
+    }
+}
+

ECommerce.BusinessEvents/Infrastructure/NoOpTransactionManager.cs

@@ -0,0 +1,14 @@
+using System;
+using System.Threading.Tasks;
+
+namespace ECommerce.BusinessEvents.Infrastructure
+{
+    public class NoOpTransactionManager : ITransactionManager
+    {
+        public Task BeginTransactionAsync() => Task.CompletedTask;
+        public Task CommitAsync() => Task.CompletedTask;
+        public Task RollbackAsync() => Task.CompletedTask;
+        public ValueTask DisposeAsync() => ValueTask.CompletedTask;
+    }
+}
+

ECommerce.BusinessEvents/Services/EventTrackingService.cs

@@ -7,14 +7,16 @@
 using ECommerce.Contracts.DTOs;
 using ECommerce.Contracts.Interfaces;
 using ECommerce.Common;
+using ECommerce.BusinessEvents.Infrastructure;
 
 namespace ECommerce.BusinessEvents.Services
 {
     public class EventTrackingService(
         BusinessEventDbContext dbContext,
         SchemaRegistryService schemaRegistry,
         IJsonSchemaValidator schemaValidator,
-        ILogger<EventTrackingService> logger) : IBusinessEventService, IEventRetrievalService
+        ILogger<EventTrackingService> logger,
+        ITransactionManager transactionManager) : IBusinessEventService, IEventRetrievalService
     {
         public async Task<Result<Unit, string>> TrackEventAsync(BusinessEventDto businessEventDto)
         {
@@ -41,9 +43,7 @@ public async Task<Result<Unit, string>> TrackEventAsync(BusinessEventDto busines
                 return Result<Unit, string>.Failure(validationResult.Error!);
             }
 
-            // Use transaction to ensure both BusinessEvent and BusinessEventMetadata are saved together
-            using var transaction = await dbContext.Database.BeginTransactionAsync();
-
+            await transactionManager.BeginTransactionAsync();
             try
             {
                 var businessEvent = new BusinessEvent
@@ -75,20 +75,24 @@ public async Task<Result<Unit, string>> TrackEventAsync(BusinessEventDto busines
 
                 if (!metadataResult.IsSuccess)
                 {
-                    await transaction.RollbackAsync();
+                    await transactionManager.RollbackAsync();
                     return Result<Unit, string>.Failure($"Metadata save failed: {metadataResult.Error}");
                 }
 
-                await transaction.CommitAsync();
+                await transactionManager.CommitAsync();
                 logger.LogInformation("Successfully tracked business event {EventId} with metadata", businessEvent.EventId);
 
                 return Result<Unit, string>.Success(new Unit());
             }
             catch (Exception ex)
             {
-                await transaction.RollbackAsync();
-                logger.LogError(ex, "Transaction failed while tracking business event for entity {EntityType}:{EntityId}", entityType, businessEventDto.EntityId);
-                return Result<Unit, string>.Failure($"Transaction failed: {ex.Message}");
+                logger.LogError(ex, "Failed to track business event for entity type {EntityType}", entityType);
+                await transactionManager.RollbackAsync();
+                return Result<Unit, string>.Failure($"Failed to track business event: {ex.Message}");
+            }
+            finally
+            {
+                await transactionManager.DisposeAsync();
             }
         }
 

ECommerceApp.IntegrationTests/CustomWebApplicationFactory.cs

@@ -8,7 +8,6 @@
 using Microsoft.Extensions.DependencyInjection;
 
 namespace ECommerceApp.IntegrationTests;
-
 public class CustomWebApplicationFactory<TStartup> : WebApplicationFactory<TStartup>
     where TStartup : class
 {