Skip to content

Updater loses retryable pkexec auth-cancel state after signed-package refactor #1442

Description

@kassi0-peia

47f6d69 (refactor: rebuild updates from signed Linux packages) removed the updater's special handling for pkexec exit codes 126/127.

Before that refactor, failed authentication kept the candidate retryable and deferred another automatic attempt until a later app-exit cycle. The implementation used pkexec_authentication_was_not_obtained(), install_auth_retry_is_blocked(), and persisted notified_events state.

The refactor removed those helpers/state and now routes every nonzero privileged-install exit through the generic failure path.

This also disagrees with the existing CHANGELOG entry stating that pkexec authentication failures (126/127) keep the candidate ReadyToInstall rather than permanently marking it Failed.

Restoring only 126/127 -> ReadyToInstall would not be sufficient because the old retry-suppression mechanism was removed in the same refactor; without an equivalent candidate-scoped retry/backoff marker, the daemon could repeatedly trigger authentication prompts.

Expected behavior: authentication cancellation/failure before package mutation should remain safely retryable without prompting again every reconcile cycle.

Regression point: 47f6d69dd4e9b56a4d91202eaff230cddf04fbf3.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions