Skip to content

Commit af67b24

Browse files
committed
Fixes
1 parent cf3cf83 commit af67b24

8 files changed

Lines changed: 26 additions & 20 deletions

File tree

spenttime-api/src/main/java/com/github/imdmk/spenttime/user/UserCache.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,12 @@ public class UserCache {
2323

2424
public void put(User user) {
2525
this.uuidUserCache.put(user.getUuid(), user);
26+
this.nameUserCache.put(user.getName(), user);
2627
}
2728

28-
public void remove(UUID uuid) {
29-
this.uuidUserCache.invalidate(uuid);
29+
public void remove(User user) {
30+
this.uuidUserCache.invalidate(user.getUuid());
31+
this.nameUserCache.invalidate(user.getName());
3032
}
3133

3234
public Optional<User> get(UUID uuid) {

spenttime-api/src/main/java/com/github/imdmk/spenttime/user/repository/UserRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public interface UserRepository {
1717

1818
CompletableFuture<User> save(User user);
1919

20-
CompletableFuture<Void> delete(UUID uuid);
20+
CompletableFuture<Void> delete(User user);
2121

2222
CompletableFuture<Void> resetGlobalSpentTime();
2323
}

spenttime-api/src/main/java/com/github/imdmk/spenttime/user/repository/impl/DaoUserRepositoryImpl.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ public DaoUserRepositoryImpl(ConnectionSource connectionSource, UserCache userCa
3737
public CompletableFuture<Optional<User>> findByUUID(UUID uuid) {
3838
return CompletableFuture.supplyAsync(() -> {
3939
try {
40-
User user = this.userDao.queryBuilder()
40+
Optional<User> userOptional = Optional.ofNullable(this.userDao.queryBuilder()
4141
.where().eq("uuid", uuid)
42-
.queryForFirst();
42+
.queryForFirst());
4343

44-
this.userCache.put(user);
44+
userOptional.ifPresent(this.userCache::put);
4545

46-
return Optional.ofNullable(user);
46+
return userOptional;
4747
}
4848
catch (SQLException sqlException) {
4949
throw new CompletionException(sqlException);
@@ -54,13 +54,13 @@ public CompletableFuture<Optional<User>> findByUUID(UUID uuid) {
5454
@Override
5555
public Optional<User> findByName(String name) {
5656
try {
57-
User user = this.userDao.queryBuilder()
57+
Optional<User> userOptional = Optional.ofNullable(this.userDao.queryBuilder()
5858
.where().eq("name", name)
59-
.queryForFirst();
59+
.queryForFirst());
6060

61-
this.userCache.put(user);
61+
userOptional.ifPresent(this.userCache::put);
6262

63-
return Optional.ofNullable(user);
63+
return userOptional;
6464
}
6565
catch (SQLException sqlException) {
6666
throw new CompletionException(sqlException);
@@ -101,11 +101,11 @@ public CompletableFuture<User> save(User user) {
101101
}
102102

103103
@Override
104-
public CompletableFuture<Void> delete(UUID uuid) {
104+
public CompletableFuture<Void> delete(User user) {
105105
return CompletableFuture.runAsync(() -> {
106106
try {
107-
this.userDao.deleteById(uuid);
108-
this.userCache.remove(uuid);
107+
this.userDao.deleteById(user.getUuid());
108+
this.userCache.remove(user);
109109
}
110110
catch (SQLException sqlException) {
111111
throw new CompletionException(sqlException);

spenttime-api/src/main/java/com/github/imdmk/spenttime/user/repository/impl/EmptyUserRepositoryImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public CompletableFuture<User> save(User user) {
3131
}
3232

3333
@Override
34-
public CompletableFuture<Void> delete(UUID uuid) {
34+
public CompletableFuture<Void> delete(User user) {
3535
return CompletableFuture.failedFuture(new UnsupportedOperationException());
3636
}
3737

spenttime-plugin/build.gradle.kts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,15 @@ bukkit {
3535
name = "SpentTime"
3636
version = "${project.version}"
3737
apiVersion = "1.17"
38-
main = "com.github.imdmk.spenttime.plugin.SpentTimePlugin"
38+
main = "com.github.imdmk.spenttime.SpentTimePlugin"
3939
author = "DMK (dominiks8318@gmail.com)"
4040
description = "An efficient plugin for calculating your time spent in the game with many features and configuration possibilities."
4141
website = "https://github.com/imDMK/SpentTime"
4242

4343
}
4444

4545
tasks.withType<ShadowJar> {
46-
archiveFileName.set("${project.name} v${project.version}.jar")
46+
archiveFileName.set("SpentTime v${project.version}.jar")
4747

4848
dependsOn("checkstyleMain")
4949
dependsOn("checkstyleTest")
@@ -69,7 +69,6 @@ tasks.withType<ShadowJar> {
6969
"net.kyori",
7070
"org.bstats",
7171
"org.json",
72-
"org.slf4j",
7372
"org.yaml",
7473
"org.checkerframework",
7574
).forEach { lib ->

spenttime-plugin/src/main/java/com/github/imdmk/spenttime/litecommands/LiteCommandsProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.github.imdmk.spenttime.configuration.PluginConfiguration;
44
import com.github.imdmk.spenttime.gui.SpentTimeTopGui;
55
import com.github.imdmk.spenttime.litecommands.argument.PlayerArgument;
6+
import com.github.imdmk.spenttime.litecommands.argument.UserArgument;
67
import com.github.imdmk.spenttime.litecommands.contextual.PlayerContextual;
78
import com.github.imdmk.spenttime.litecommands.handler.MissingPermissionHandler;
89
import com.github.imdmk.spenttime.litecommands.handler.UsageHandler;
@@ -19,7 +20,6 @@
1920
import com.github.imdmk.spenttime.user.User;
2021
import com.github.imdmk.spenttime.user.UserCache;
2122
import com.github.imdmk.spenttime.user.UserService;
22-
import com.github.imdmk.spenttime.litecommands.argument.UserArgument;
2323
import com.github.imdmk.spenttime.user.repository.UserRepository;
2424
import dev.rollczi.litecommands.LiteCommands;
2525
import dev.rollczi.litecommands.bukkit.LiteBukkitFactory;

spenttime-plugin/src/main/java/com/github/imdmk/spenttime/update/UpdateController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class UpdateController implements Listener {
2121

2222
private static final String PREFIX = "<dark_gray>[<rainbow>SpentTime<dark_gray>]";
2323

24-
private static final Notification UPDATE_AVAILABLE = new Notification(NotificationType.CHAT, PREFIX + " <yellow>A new version is available: {TAG}\n<yellow>Download it here: {URL}");
24+
private static final Notification UPDATE_AVAILABLE = new Notification(NotificationType.CHAT, PREFIX + " <red><yellow>A new version is available: {TAG}\n<green>Download it here: {URL}");
2525
private static final Notification UPDATE_EXCEPTION = new Notification(NotificationType.CHAT, PREFIX + "<red>An error occurred while checking for update: {MESSAGE}");
2626

2727
private final Logger logger;

spenttime-plugin/src/main/java/com/github/imdmk/spenttime/user/BukkitPlayerSpentTimeService.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ public Duration getSpentTime(OfflinePlayer player) {
2121
return Duration.ofSeconds(secondsPlayed);
2222
}
2323

24+
public Duration getSpentTime(UUID playerUuid) {
25+
long secondsPlayed = this.server.getOfflinePlayer(playerUuid).getStatistic(Statistic.PLAY_ONE_MINUTE) / 20;
26+
return Duration.ofSeconds(secondsPlayed);
27+
}
28+
2429
public void resetSpentTime(OfflinePlayer offlinePlayer) {
2530
offlinePlayer.setStatistic(Statistic.PLAY_ONE_MINUTE, 0);
2631
}

0 commit comments

Comments
 (0)