Skip to content
This repository was archived by the owner on Dec 22, 2024. It is now read-only.

Commit b1a95e1

Browse files
committed
remove healthcheck
1 parent 61527fe commit b1a95e1

3 files changed

Lines changed: 5 additions & 23 deletions

File tree

.github/update_readme.sh

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ See [package_versions.txt](package_versions.txt) for a full list of the packages
2626
-e PASSWORD= \`#webui password\` \\
2727
-e LICENCE= \`#see below\` \\
2828
-e MODULE= \`#see below\` \\
29-
-v :/config \\
29+
-v <path to appdata>:/config \\
3030
--mac-address=xx:xx:xx:xx:xx:xx \`#see below\` \\
3131
--restart unless-stopped \\
3232
vcxpz/amp
@@ -35,7 +35,7 @@ See [package_versions.txt](package_versions.txt) for a full list of the packages
3535
3636
## Please Note
3737
38-
As it takes more than 10 seconds (the default timeout for Docker) for AMP to do a graceful shutdown, make sure you have no running modules. Stopping your container via Docker while you have running modules may cause corruption as Docker will kill the container. The easiest way to do a graceful shutdown is to open a console to the container and executing \`amp stop\`. This command basically does \`s6-svc -to /var/run/s6/services/amp\`. Which sends a SIGTERM to AMP then tells \`s6\` not to restart AMP after the service it is terminated.
38+
As it takes more than 10 seconds (the default timeout for Docker) for AMP to do a graceful shutdown, make sure you have no running modules. Stopping your container via Docker while you have running modules may cause corruption as Docker will kill the container. The easiest way to do a graceful shutdown is to open a console to the container and execute \`amp stop\`. This command basically does \`s6-svc -to /var/run/s6/services/amp\`. Which sends a SIGTERM to AMP then tells \`s6\` not to restart AMP after the service it is terminated.
3939
4040
## Supported Modules
4141
@@ -104,12 +104,6 @@ Just a quick note about ports: some games use TCP, some games use UDP. Make sure
104104
105105
## Environment Variables
106106
107-
### Debug
108-
109-
| Name | Description | Default Value |
110-
| ------- | ------------------------------------------------------- | ------------- |
111-
| \`DEBUG\` | Set \`true\` to show AMP startup output in the docker log | \`false\` |
112-
113107
### Module
114108
115109
| Name | Description | Default Value |

Dockerfile

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ RUN set -x && \
4444
/tmp/ampinstmgr.zip -d \
4545
/app/amp/ && \
4646
ln -s /app/amp/ampinstmgr /usr/bin/ampinstmgr && \
47-
echo "**** download AMPCache-${VERSION//.}.zip ****" && \
47+
echo "**** download AMPCache-${VERSION//./}.zip ****" && \
4848
curl --silent -o \
49-
/app/amp/AMPCache-${VERSION//.}.zip -L \
49+
/app/amp/AMPCache-${VERSION//./}.zip -L \
5050
"http://cubecoders.com/Downloads/AMP_Latest.zip" && \
5151
echo "**** cleanup ****" && \
5252
apk del --purge \
@@ -57,10 +57,6 @@ RUN set -x && \
5757
# add local files
5858
COPY root/ /
5959

60-
# http healthcheck
61-
HEALTHCHECK --start-period=10s --timeout=5s \
62-
CMD wget -qO /dev/null 'http://localhost' || exit 1
63-
6460
# ports and volumes
6561
EXPOSE 8080
6662
VOLUME /config

root/etc/services.d/amp/run

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,5 @@
11
#!/usr/bin/with-contenv bash
22

3-
redirect_cmd() {
4-
if [[ "${DEBUG}" == "true" ]]; then
5-
"$@"
6-
else
7-
"$@" >/dev/null 2>&1
8-
fi
9-
}
10-
113
_term() {
124
echo "Caught SIGTERM signal!"
135
redirect_cmd s6-setuidgid abc \
@@ -16,7 +8,7 @@ _term() {
168

179
trap _term SIGTERM
1810

19-
redirect_cmd s6-setuidgid abc \
11+
s6-setuidgid abc \
2012
ampinstmgr StartBoot
2113

2214
PID=$(pgrep tmux)

0 commit comments

Comments
 (0)