Do not hide the login page in the Google service (vibe-kanban 007f2131)

In the Google service, due to the ancestor class(es), the login in the oauth callback is hidden behind the spinner page ("showSpinnerPage"). Instead, it should remain visible.

Also, I suspect that the actual part that should be hidden behind a spinner page which is in prepare() actually isn't. (But I'm not 100% sure.)

Author: hynek-urban

src/services/google.ts

@@ -2,10 +2,11 @@
  * Google service implementation with OAuth flow.
  */
 
-import type { Response, BrowserContext, Page } from 'playwright';
+import type { Browser, BrowserContext, Page, Response } from 'playwright';
 import { ApiCredentialStatus, ApiCredentials, OAuthCredentials } from '../apiCredentials.js';
 import {
   generateLatchkeyAppName,
+  showSpinnerPage,
   withTempBrowserContext,
   type BrowserLaunchOptions,
 } from '../playwrightUtils.js';
@@ -504,6 +505,18 @@ class GoogleServiceSession extends BrowserFollowupServiceSession {
     return this.loginDetector.isLoggedIn;
   }
 
+  /**
+   * Override to skip the spinner page since the OAuth flow requires user interaction
+   * (granting consent on Google's authorization page).
+   */
+  protected override finalizeCredentials(
+    _browser: Browser,
+    context: BrowserContext,
+    oldCredentials?: ApiCredentials
+  ): Promise<ApiCredentials | null> {
+    return this.performBrowserFollowup(context, oldCredentials);
+  }
+
   protected async performBrowserFollowup(
     context: BrowserContext,
     oldCredentials?: ApiCredentials
@@ -647,6 +660,9 @@ export class Google implements Service {
       // Wait for user to log in
       await waitForGoogleLogin(page);
 
+      // Show spinner while performing automated setup
+      await showSpinnerPage(context, this.name);
+
       // Create project, enable APIs, and create OAuth client
       const projectSlug = await createProject(page);
       await enableGoogleApis(page, projectSlug);