Fix an edge case in google's auth browser command.

Author: hynek-urban

src/services/core/base.ts

@@ -103,6 +103,22 @@ export function isBrowserClosedError(error: Error): boolean {
   );
 }
 
+/**
+ * Detects the Playwright/CDP error raised when a response body can no longer be
+ * retrieved (`Network.getResponseBody` reports "No resource with given
+ * identifier found"). This happens for responses that retain no readable body —
+ * redirects, evicted or cached resources, or bodies fetched after the page has
+ * navigated onward. Callers that read response bodies opportunistically should
+ * treat this as inconclusive rather than fatal.
+ */
+export function isResponseBodyUnavailableError(error: Error): boolean {
+  const message = error.message.toLowerCase();
+  return (
+    message.includes('no resource with given identifier') ||
+    message.includes('network.getresponsebody')
+  );
+}
+
 export function isTimeoutError(error: Error): boolean {
   return error.name === 'TimeoutError';
 }

src/services/google/base.ts

@@ -32,6 +32,7 @@ import {
   LoginFailedError,
   LoginCancelledError,
   isBrowserClosedError,
+  isResponseBodyUnavailableError,
   isTimeoutError,
 } from '../core/base.js';
 import type { EncryptedStorage } from '../../encryptedStorage.js';
@@ -530,9 +531,14 @@ function checkGoogleLoginResponse(
         .catch((error: unknown) => {
           // The response body can become unreadable if the page/context
           // closes while it's still being read (e.g. the automation
-          // navigates onward, or the user closes the browser). Treat that
-          // specific race as inconclusive; let any other error propagate.
-          if (error instanceof Error && isBrowserClosedError(error)) {
+          // navigates onward, or the user closes the browser), or if the
+          // response simply retains no readable body (redirects, cached or
+          // evicted resources). Login detection here is best-effort, so treat
+          // those cases as inconclusive; let any other error propagate.
+          if (
+            error instanceof Error &&
+            (isBrowserClosedError(error) || isResponseBodyUnavailableError(error))
+          ) {
             return;
           }
           throw error;

tests/serviceErrors.test.ts

@@ -0,0 +1,31 @@
+import { describe, it, expect } from 'vitest';
+import {
+  isBrowserClosedError,
+  isResponseBodyUnavailableError,
+} from '../src/services/core/base.js';
+
+describe('isResponseBodyUnavailableError', () => {
+  it('recognizes the CDP "no resource with given identifier" error', () => {
+    const error = new Error(
+      'Protocol error (Network.getResponseBody): No resource with given identifier found'
+    );
+    expect(isResponseBodyUnavailableError(error)).toBe(true);
+  });
+
+  it('matches case-insensitively', () => {
+    expect(
+      isResponseBodyUnavailableError(new Error('NO RESOURCE WITH GIVEN IDENTIFIER FOUND'))
+    ).toBe(true);
+  });
+
+  it('does not match unrelated errors', () => {
+    expect(isResponseBodyUnavailableError(new Error('something else went wrong'))).toBe(false);
+  });
+
+  it('is distinct from browser-closed errors', () => {
+    const bodyError = new Error(
+      'Protocol error (Network.getResponseBody): No resource with given identifier found'
+    );
+    expect(isBrowserClosedError(bodyError)).toBe(false);
+  });
+});